8000 Remove `@Path`'s placeholder by shiraji · Pull Request #1631 · androidannotations/androidannotations · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Conversation

@shiraji
Copy link
Contributor
@shiraji shiraji commented Nov 18, 2015

see #1602 and #1615
#1615 only implementing @Body not replacting @Path placeholder function.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could more specific here? (The user must add @Path here, not?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or there are missing url variables corresponding to the @RequiresCookieInUrl annotation.

@shiraji
Copy link
Contributor Author
shiraji commented Nov 18, 2015

Fixed it.

@shiraji
Copy link
Contributor Author
shiraji commented Nov 18, 2015

Wiki is updated, too.

@WonderCsabo
Copy link
Member

Can you squash the commits (so only two commits remain).

@shiraji
Copy link
Contributor Author
shiraji commented Nov 19, 2015

Squashed.

WonderCsabo added a commit that referenced this pull request Nov 19, 2015
@WonderCsabo WonderCsabo merged commit ab3a53d into androidannotations:develop Nov 19, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Nov 19, 2015
@WonderCsabo
Copy link
Member

Thanks, great work. I also merged the wiki.

@shiraji shiraji deleted the 1602_remove_path_placeholder branch November 19, 2015 13:11
@shiraji
Copy link
Contributor Author
shiraji commented Nov 19, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0