Added @Body #1615
Added @Body #1615
Conversation
|
I think We should have a validation method which validates all rest methods in the interface has all its parameters annotated with one appropriate annotation. Another method which validates that So one of the reasons of this PR that now all method parameteres are annotated, so it is easier to validate and handle them. |
|
I will squash commits later. I have a question about @Post("/events/{date}?myCookieInUrl={myCookieInUrl}")
@RequiresCookieInUrl("myCookieInUrl")I thought it must have url placeholder so I changed test cases. |
|
Thanks for all your work so far!
|
|
No problem! I will add more tests for this. |
|
Does |
|
No, it does not.
|
|
OK, let me fix that. |
…es validations
|
Done. Could you review this pull request? Thanks. |
There was a problem hiding this comment.
These three validations are present in multiple handlers, what about extracting to a validator method?
There was a problem hiding this comment.
Sure. how about doesNotHaveRestEntityAnnotatedParameters?
There was a problem hiding this comment.
You mean doesNotHaveRequestEntityAnnotatedParameters? It would be great.
There was a problem hiding this comment.
Yea. sorry for typo.
|
@shiraji you should review all javadoc for REST method annotations which can have |
|
@WonderCsabo do you prefer to have separate commits for code review? and then after you review the commits, squash these commits? |
|
Yeah, it will help reviewing, thanks! |
|
OK, I am really sorry for careless coding. I should have code very very very carefully. I will fix this as soon as possible. |
|
@shiraji no worries! |
|
@shiraji is this ready to be reviewed? |
|
@WonderCsabo not yet. I found multiple problems with validations. Hopefully, I will complete this within a few days. If I think these problems are hard to overcome, I may ask your help. Thanks. |
|
@WonderCsabo it's ready for review, now. |
|
@shiraji great work. Can you update the wiki as well? |
|
Thanks, it maybe too late but I thought you want me to squash the commits. I'll update wiki and let you know. |
see #1602
@Bodyannotation