Typed param

nexxai · nexxai · commit 9a6733d3a16e · 2023-08-17T10:42:38.000-06:00
diff --git a/src/Commands/MinifyApplicationCommand.php b/src/Commands/MinifyApplicationCommand.php
@@ -86,26 +86,26 @@ protected function removeIgnoredFilesAndFolders(string $appPath): void
         }
     }
 
-    private function deleteDirectoryRecursive($dir)
+    private function deleteDirectoryRecursive(string $directory)
     {
-        if (! file_exists($dir)) {
+        if (! file_exists($directory)) {
             return true;
         }
 
-        if (! is_dir($dir)) {
-            return unlink($dir);
+        if (! is_dir($directory)) {
+            return unlink($directory);
         }
 
-        foreach (scandir($dir) as $item) {
+        foreach (scandir($directory) as $item) {
             if ($item == '.' || $item == '..') {
                 continue;
             }
 
-            if (! $this->deleteDirectoryRecursive($dir.'/'.$item)) {
+            if (! $this->deleteDirectoryRecursive($directory.'/'.$item)) {
                 return false;
             }
         }
 
-        return rmdir($dir);
+        return rmdir($directory);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -86,26 +86,26 @@ protected function removeIgnoredFilesAndFolders(string $appPath): void`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`89`		`- private function deleteDirectoryRecursive($dir)`
	`89`	`+ private function deleteDirectoryRecursive(string $directory)`
`90`	`90`	`{`
`91`		`- if (! file_exists($dir)) {`
	`91`	`+ if (! file_exists($directory)) {`
`92`	`92`	`return true;`
`93`	`93`	`}`
`94`	`94`
`95`		`- if (! is_dir($dir)) {`
`96`		`- return unlink($dir);`
	`95`	`+ if (! is_dir($directory)) {`
	`96`	`+ return unlink($directory);`
`97`	`97`	`}`
`98`	`98`
`99`		`- foreach (scandir($dir) as $item) {`
	`99`	`+ foreach (scandir($directory) as $item) {`
`100`	`100`	`if ($item == '.' \|\| $item == '..') {`
`101`	`101`	`continue;`
`102`	`102`	`}`
`103`	`103`
`104`		`- if (! $this->deleteDirectoryRecursive($dir.'/'.$item)) {`
	`104`	`+ if (! $this->deleteDirectoryRecursive($directory.'/'.$item)) {`
`105`	`105`	`return false;`
`106`	`106`	`}`
`107`	`107`	`}`
`108`	`108`
`109`		`- return rmdir($dir);`
	`109`	`+ return rmdir($directory);`
`110`	`110`	`}`
`111`	`111`	`}`