minor symfony#24582 [DI] Enhance service locator error message (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit beed426e9ac0 · 2017-10-20T12:00:26.000-07:00
This PR was merged into the 3.3 branch. Discussion ---------- [DI] Enhance service locator error message | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#24555 | License | MIT | Doc PR | - See linked issue. Commits ------- fdb0ea9 [DI] Enhance service locator error message
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ServiceLocatorTagPass.php
@@ -78,6 +78,9 @@ protected function processValue($value, $isRoot = false)
     public static function register(ContainerBuilder $container, array $refMap)
     {
         foreach ($refMap as $id => $ref) {
+            if (!$ref instanceof Reference) {
+                throw new InvalidArgumentException(sprintf('Invalid service locator definition: only services can be referenced, "%s" found for key "%s". Inject parameter values using constructors instead.', is_object($ref) ? get_class($ref) : gettype($ref), $id));
+            }
             $refMap[$id] = new ServiceClosureArgument($ref);
         }
         ksort($refMap);

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,9 @@ protected function processValue($value, $isRoot = false)`
`78`	`78`	`public static function register(ContainerBuilder $container, array $refMap)`
`79`	`79`	`{`
`80`	`80`	`foreach ($refMap as $id => $ref) {`
	`81`	`+ if (!$ref instanceof Reference) {`
	`82`	`+ throw new InvalidArgumentException(sprintf('Invalid service locator definition: only services can be referenced, "%s" found for key "%s". Inject parameter values using constructors instead.', is_object($ref) ? get_class($ref) : gettype($ref), $id));`
	`83`	`+ }`
`81`	`84`	`$refMap[$id] = new ServiceClosureArgument($ref);`
`82`	`85`	`}`
`83`	`86`	`ksort($refMap);`