[Contracts] Add missing @return annotations

nicolas-grekas · nicolas-grekas · commit bafecf2b49e4 · 2021-07-13T11:33:53.000+02:00
diff --git a/src/Symfony/Contracts/Cache/CacheTrait.php b/src/Symfony/Contracts/Cache/CacheTrait.php
@@ -27,6 +27,8 @@ trait CacheTrait
 {
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function get(string $key, callable $callback, float $beta = null, array &$metadata = null)
     {
diff --git a/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php b/src/Symfony/Contracts/HttpClient/Test/TestHttpServer.php
@@ -21,6 +21,9 @@ class TestHttpServer
 {
     private static $process = [];
 
+    /**
+     * @return Process
+     */
     public static function start(int $port = 8057)
     {
         if (isset(self::$process[$port])) {
diff --git a/src/Symfony/Contracts/Service/ServiceSubscriberTrait.php b/src/Symfony/Contracts/Service/ServiceSubscriberTrait.php
@@ -52,6 +52,8 @@ public static function getSubscribedServices(): array
 
     /**
      * @required
+     *
+     * @return ContainerInterface|null
      */
     public function setContainer(ContainerInterface $container)
     {
diff --git a/src/Symfony/Contracts/Service/Test/ServiceLocatorTest.php b/src/Symfony/Contracts/Service/Test/ServiceLocatorTest.php
@@ -17,6 +17,9 @@
 
 abstract class ServiceLocatorTest extends TestCase
 {
+    /**
+     * @return ContainerInterface
+     */
     protected function getServiceLocator(array $factories)
     {
         return new class($factories) implements ContainerInterface {
diff --git a/src/Symfony/Contracts/Tests/Service/ServiceSubscriberTraitTest.php b/src/Symfony/Contracts/Tests/Service/ServiceSubscriberTraitTest.php
@@ -42,7 +42,7 @@ public function aParentService(): Service1
     {
     }
 
-    public function setContainer(ContainerInterface $container)
+    public function setContainer(ContainerInterface $container): ContainerInterface
     {
         return $container;
     }
diff --git a/src/Symfony/Contracts/Translation/Test/TranslatorTest.php b/src/Symfony/Contracts/Translation/Test/TranslatorTest.php
@@ -43,6 +43,9 @@ protected function tearDown(): void
         \Locale::setDefault($this->defaultLocale);
     }
 
+    /**
+     * @return TranslatorInterface
+     */
     public function getTranslator()
     {
         return new class() implements TranslatorInterface {

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,8 @@ trait CacheTrait`
`27`	`27`	`{`
`28`	`28`	`/**`
`29`	`29`	`* {@inheritdoc}`
	`30`	`+ *`
	`31`	`+ * @return mixed`
`30`	`32`	`*/`
`31`	`33`	`public function get(string $key, callable $callback, float $beta = null, array &$metadata = null)`
`32`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,6 +21,9 @@ class TestHttpServer`
`21`	`21`	`{`
`22`	`22`	`private static $process = [];`
`23`	`23`
	`24`	`+ /**`
	`25`	`+ * @return Process`
	`26`	`+ */`
`24`	`27`	`public static function start(int $port = 8057)`
`25`	`28`	`{`
`26`	`29`	`if (isset(self::$process[$port])) {`
Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,8 @@ public static function getSubscribedServices(): array`
`52`	`52`
`53`	`53`	`/**`
`54`	`54`	`* @required`
	`55`	`+ *`
	`56`	`+ * @return ContainerInterface\|null`
`55`	`57`	`*/`
`56`	`58`	`public function setContainer(ContainerInterface $container)`
`57`	`59`	`{`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,9 @@`
`17`	`17`
`18`	`18`	`abstract class ServiceLocatorTest extends TestCase`
`19`	`19`	`{`
	`20`	`+ /**`
	`21`	`+ * @return ContainerInterface`
	`22`	`+ */`
`20`	`23`	`protected function getServiceLocator(array $factories)`
`21`	`24`	`{`
`22`	`25`	`return new class($factories) implements ContainerInterface {`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function aParentService(): Service1`
`42`	`42`	`{`
`43`	`43`	`}`
`44`	`44`
`45`		`- public function setContainer(ContainerInterface $container)`
	`45`	`+ public function setContainer(ContainerInterface $container): ContainerInterface`
`46`	`46`	`{`
`47`	`47`	`return $container;`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,9 @@ protected function tearDown(): void`
`43`	`43`	`\Locale::setDefault($this->defaultLocale);`
`44`	`44`	`}`
`45`	`45`
	`46`	`+ /**`
	`47`	`+ * @return TranslatorInterface`
	`48`	`+ */`
`46`	`49`	`public function getTranslator()`
`47`	`50`	`{`
`48`	`51`	`return new class() implements TranslatorInterface {`