Update for @nicolas-grekas's code review

alexpott · alexpott · commit ab7868547a45 · 2019-04-23T19:16:33.000+01:00
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
@@ -219,12 +219,11 @@ public function regenerate($destroy = false, $lifetime = null)
      */
     public function save()
     {
-        // In PHP <7.2 session_write_close() does not error if the session is
-        // not started.
+        // In PHP <7.2 session_write_close() returns void if the session is not started.
+        // @see https://www.php.net/manual/function.session-write-close.php
         if (!$this->started) {
             return;
         }
-
         $session = $_SESSION;
 
         foreach ($this->bags as $bag) {

Original file line number	Diff line number	Diff line change
`@@ -219,12 +219,11 @@ public function regenerate($destroy = false, $lifetime = null)`
`219`	`219`	`*/`
`220`	`220`	`public function save()`
`221`	`221`	`{`
`222`		`- // In PHP <7.2 session_write_close() does not error if the session is`
`223`		`- // not started.`
	`222`	`+ // In PHP <7.2 session_write_close() returns void if the session is not started.`
	`223`	`+ // @see https://www.php.net/manual/function.session-write-close.php`
`224`	`224`	`if (!$this->started) {`
`225`	`225`	`return;`
`226`	`226`	`}`
`227`		`-`
`228`	`227`	`$session = $_SESSION;`
`229`	`228`
`230`	`229`	`foreach ($this->bags as $bag) {`