ref(replay): Add further logging to network body parsing (getsentry#9566)

mydea · web-flow · commit 56980948c206 · 2023-11-16T13:44:34.000+01:00
We got somewhat closer to figuring out the problem there. Based on this comment: getsentry#9339 (comment) > The requests are now showing with the request body, but the response body is "undefined" It seems that the problem is with parsing the response body for a XHR request. I added some more logging there, to be able to debug this further.
diff --git a/packages/replay/src/coreHandlers/util/networkUtils.ts b/packages/replay/src/coreHandlers/util/networkUtils.ts
@@ -78,6 +78,8 @@ export function getBodyString(body: unknown): string | undefined {
     __DEBUG_BUILD__ && logger.warn('[Replay] Failed to serialize body', body);
   }
 
+  __DEBUG_BUILD__ && logger.info('[Replay] Skipping network body because of body type', body);
+
   return undefined;
 }
 
diff --git a/packages/replay/src/coreHandlers/util/xhrUtils.ts b/packages/replay/src/coreHandlers/util/xhrUtils.ts
@@ -135,15 +135,24 @@ function getResponseHeaders(xhr: XMLHttpRequest): Record<string, string> {
 }
 
 function _getXhrResponseBody(xhr: XMLHttpRequest): string | undefined {
+  // We collect errors that happen, but only log them if we can't get any response body
+  const errors: unknown[] = [];
+
   try {
     return xhr.responseText;
-  } catch {} // eslint-disable-line no-empty
+  } catch (e) {
+    errors.push(e);
+  }
 
   // Try to manually parse the response body, if responseText fails
   try {
     const response = xhr.response;
     return getBodyString(response);
-  } catch {} // eslint-disable-line no-empty
+  } catch (e) {
+    errors.push(e);
+  }
+
+  __DEBUG_BUILD__ && logger.warn('[Replay] Failed to get xhr response body', ...errors);
 
   return undefined;
 }

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,8 @@ export function getBodyString(body: unknown): string \| undefined {`
`78`	`78`	`__DEBUG_BUILD__ && logger.warn('[Replay] Failed to serialize body', body);`
`79`	`79`	`}`
`80`	`80`
	`81`	`+ __DEBUG_BUILD__ && logger.info('[Replay] Skipping network body because of body type', body);`
	`82`	`+`
`81`	`83`	`return undefined;`
`82`	`84`	`}`
`83`	`85`