[1.7.x] Fixed #23333 -- Made urlsafe_base64_decode() return proper type on Python 3.

LilyAcorn · timgraham · commit d83066500713 · 2014-10-08T14:03:46.000-04:00
Backport of 03d8916 from master
diff --git a/django/utils/http.py b/django/utils/http.py
@@ -10,7 +10,7 @@
 from email.utils import formatdate
 
 from django.utils.datastructures import MultiValueDict
-from django.utils.encoding import force_str, force_text
+from django.utils.encoding import force_bytes, force_str, force_text
 from django.utils.functional import allow_lazy
 from django.utils import six
 from django.utils.six.moves.urllib.parse import (
@@ -224,7 +224,7 @@ def urlsafe_base64_decode(s):
     Decodes a base64 encoded string, adding back any trailing equal signs that
     might have been stripped.
     """
-    s = s.encode('utf-8')  # base64encode should only return ASCII.
+    s = force_bytes(s)
     try:
         return base64.urlsafe_b64decode(s.ljust(len(s) + len(s) % 4, b'='))
     except (LookupError, BinasciiError) as e:
diff --git a/docs/releases/1.7.1.txt b/docs/releases/1.7.1.txt
@@ -103,3 +103,6 @@ Bugfixes
 
 * Fixed missing ``get_or_create`` and ``update_or_create`` on related managers
   causing ``IntegrityError`` (:ticket:`23611`).
+
+* Made :func:`~django.utils.http.urlsafe_base64_decode` return the proper
+  type (byte string) on Python 3 (:ticket:`23333`).
diff --git a/tests/utils_tests/test_http.py b/tests/utils_tests/test_http.py
@@ -119,6 +119,12 @@ def test_is_safe_url(self):
                      '/url%20with%20spaces/'):
             self.assertTrue(http.is_safe_url(good_url, host='testserver'), "%s should be allowed" % good_url)
 
+    def test_urlsafe_base64_roundtrip(self):
+        bytestring = b'foo'
+        encoded = http.urlsafe_base64_encode(bytestring)
+        decoded = http.urlsafe_base64_decode(encoded)
+        self.assertEqual(bytestring, decoded)
+
 
 class ETagProcessingTests(unittest.TestCase):
     def test_parsing(self):
