8000 Comparing techreturners:master...alankm194:master · techreturners/java_coding_exercises · GitHub
[go: up one dir, main page]
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: techreturners/java_coding_exercises
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: alankm194/java_coding_exercises
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 14 files changed
  • 1 contributor

Commits on Jan 16, 2023

  1. Finished exercise 1 to 5 

    - added tests for exercise 3, 4, 5
- added new person class for ex2
- changed checkPickMultipleIceCreamFlavours test in ex3 to use assertArrayEquals
- change ex3 and ex5 test to use beforeEach instead of beforeAll
    @alankm194
    alankm194 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    d1c436f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/alankm194/java_coding_exe… 

    …rcises
    @alankm194
    alankm194 committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    a7341c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Fix changes based on feedback 

    - remove unnecessary if statements in ex2
- renamed variable string array to flavours in ex3
- replaced equals to equalsIgnoreCase in ex2
- use unused variable ageLimit instead of hardcoded int
    @alankm194
    alankm194 committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    d917e7a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Replace reverse method using stringbuilder instead

    @alankm194
    alankm194 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    7c6aa70 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary code to make it more concise. 

    - also remove unused import
    @alankm194
    alankm194 committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    6b48051 View commit details
    Browse the repository at this point in the history
Loading
0