Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 14 commits
- 32 files changed
- 1 contributor
Commits on Nov 15, 2019
Commits on Nov 18, 2019
-
- добавлено поле size для хранения количества резюме в базе - в методе getAll возвращаемый массив переименован в resumes - в методе delete удаляется последнее добавленное резюме, исправлена ошибка выхода за границы массива - в методе save добавлена проверка максимальной длины массива, если база переполнена то новое резюме не сохраняется
Commits on Nov 19, 2019
-
Исправлены ошибки, метод delete
- в методе delete вместо удаляемого элемента подставляем последний, а последнюю ячейку массива очищаем
Commits on Jan 9, 2020
-
- созданы пакеты ru.topjava.webapp.model и ru.topjava.webapp.storage - используются getter и setter для свойства uuid объекта Resume - в класс ArrayStorage добавлены методы update и getResumeIndex - методы clear и getAll реализованы с помощью методов класса java.util.Arrays
Commits on Jan 10, 2020
-
+ ArrayStorage - variables renam 10BC0 ed for readability, removed unnecessary "this" keywords - storage amount is 10000 - method clear - set to null only filled part of the storage - method getResumeIndex is private; removed check for null input, will be added in model class - method get - return null if uuid is not found + MainArray - variables renamed for readability - "update" method added + MainTestArrayStorage - variables renamed for readability
Commits on Jan 24, 2020
-
+ New files: - interface Storage - abstract class AbstractArrayStorage - class SortedArrayStorage + ArrayStorage - extends class AbstractArrayStorage + Resume - added methods equals, hashCode - implements interface Comparable + MainArray, MainTestArrayStorage - switched to SortedArrayStorage
Commits on Jan 29, 2020
-
+ MainArray - added choice between sorted and unsorted array-based storage + Resume - method compareTo, rewrited to use private variable uuid - method equals, input variable renamed for readability + AbstractArrayStorage - abstract methods moved on top - added implementation to methods save, delete - new abstract methods saveByIndex, deleteByIndex + ArrayStorage, SortedArrayStorage - removed methods save, delete - added new methods saveByIndex, deleteByIndex
-
+ AbstractArrayStorage - interface name in error messages - methods save, delete: improved code reuse + ArrayStorage, SortedArrayStorage - added @OverRide annotations - methods saveByIndex, deleteByIndex: improved code reuse
Commits on Dec 29, 2020
-
+ New files: - directory test, classes AbstractArrayStorageTest, ArrayStorageTest, SortedArrayStorageTest - package ru.topjava.webapp.exception, classes StorageException, ExistStorageException, NotExistStorageException - class MainReflection + Resume - constructors Resume() and Resume(String uuid) added, instead of method setUuid(String uuid) + AbstractArrayStorage, ArrayStorage, SortedArrayStorage - exceptions throwing added, instead of System.out.println + Gradle support added
Commits on Jan 12, 2021
-
* feature/lesson04 + New files: - directory test, classes AbstractArrayStorageTest, ArrayStorageTest, SortedArrayStorageTest - package ru.topjava.webapp.exception, classes StorageException, ExistStorageException, NotExistStorageException - class MainReflection + Resume - constructors Resume() and Resume(String uuid) added, instead of method setUuid(String uuid) + AbstractArrayStorage, ArrayStorage, SortedArrayStorage - exceptions throwing added, instead of System.out.println + Gradle support added * feature/lesson04 + AbstractArrayStorageTest - variable arrayStorage renamed to storage - parameter type in constructor changed from AbstractArrayStorage to Storage - methods save, delete: check whether element is saved/deleted and storage size is changed - method update: check whether element is updated, variable resume3Update declared inside of the method - method getAll: Assert.assertArrayEquals is used - method saveStorageFull: check that StorageException is trown only when storage is full - method setUp: remowed "throws Exception" * feature/lesson04 + Storage, AbstractArrayStorage - new method lenght() added + AbstractArrayStorageTest - method delete: empty catch() block removed - method saveStorageFull: methods size() and length() used, instead of constants
Commits on Jun 10, 2021
-
+ Storage, AbstractArrayStorage, AbstractArrayStorageTest - method lenght() deleted, constant STORAGE_LENGTH is used + new classes: ListStorage, AbstractStorage, ListStorageTest, AbstractStorageTest
Commits on Jun 16, 2021
-
* hotfix/lesson05 + ListStorage - when defining variable "storage", interface List<Resume> is used, instead of concrete class ArrayList<Resume> - method getIndex is rewritten to compare resumes by field uuid + AbstractArrayStorage, ListStorage - removed "implements Storage" + AbstractStorage, AbstractArrayStorage, ListStorage - common code moved from classes ListStorage and AbstractArrayStorage to AbstractStorage, template method pattern is used * hotfix/lesson05 + AbstractStorage - deleted methods: clearStorage, getAllFromStorage, getSizeOfStorage + SortedArrayStorage - method saveByIndex, variable resumeIndexInverted is used to get positive resume index, other variables are deleted - method deleteByIndex, variable resumeIndex is used, other variables are deleted + AbstractStorage, ListStorage, AbstractArrayStorage, SortedArrayStorage, ArrayStorage - code duplication is removed from methods "save" and "delete" + In every class - code is formatted and imports are organized * hotfix/lesson05 + AbstractStorage - abstract methodhs, inherited from interface Storage, are removed + SortedArrayStorage - variable resumeIndexInverted is changed to resumeIndexToSave = -resumeIndex - 1 + AbstractStorage, AbstractArrayStorage - new methods checkResumeCanBeFound, checkResumeCanBeSaved, checkResumeCanBeSavedToArray are created to reduce code duplication * hotfix/lesson05 + AbstractStorage - abstract methodhs, inherited from interface Storage, are removed + SortedArrayStorage - variable resumeIndexInverted is changed to resumeIndexToSave = -resumeIndex - 1 + AbstractStorage, AbstractArrayStorage - new methods checkResumeCanBeFound, checkResumeCanBeSaved, checkResumeCanBeSavedToArray are created to reduce code duplication * hotfix/lesson05 + AbstractStorage - methods checkResumeCanBeSaved and checkResumeCanBeFound renamed to findIndexIfResumeNotExist and findIndexIfResumeExist - resume index definition moved to methods findIndexIfResumeNotExist and findIndexIfResumeExist + AbstractArrayStorage - method checkResumeCanBeSavedToArray renamed to checkStorageIsNotFull
Commits on Aug 2, 2021
-
* feature/lesson05_2 + AbstractStorage - methods findIndexIfResumeNotExist, findIndexIfResumeExist is now protected - methods findIndexIfResumeNotExist, findIndexIfResumeExist, getIndex, saveByIndex, deleteByIndex, getFromStorage, updateInStorage is now return or consume resume index in type Object + AbstractArrayStorage - method checkStorageIsNotFull is now private + AbstractStorageTest - test method getAll, sorting added for the actual testing array + New classes MapStorage, MapStorageTest * feature/lesson05_2 + AbstractStorage - word "index" is replaced to "key" in variables and methods names - methods findKeyIfResumeNotExist, findKeyIfResumeExist are now private + AbstractStorage, MapStorage - new method isResumeExists + MapStorage, ListStorage - variable storage is now private
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master