use FutureWarning in settings so it's printed (pydantic#881)

samuelcolvin · web-flow · commit bd8918bfabd6 · 2019-10-10T13:24:23.000+01:00
* use FutureWarning in settings so it's printed

* fix tests

* better warning link

* change warning link
diff --git a/changes/881-samuelcolvin.md b/changes/881-samuelcolvin.md
@@ -0,0 +1 @@
+Use `FutureWarning` instead of `DeprecationWarning` when `alias` instead of `env` is used for settings models
diff --git a/pydantic/env_settings.py b/pydantic/env_settings.py
@@ -73,8 +73,9 @@ def prepare_field(cls, field: ModelField) -> None:
                 if field.has_alias:
                     warnings.warn(
                         'aliases are no longer used by BaseSettings to define which environment variables to read. '
-                        'Instead use the "env" field setting. See https://pydantic-docs.helpmanual.io/usage/settings/',
-                        DeprecationWarning,
+                        'Instead use the "env" field setting. '
+                        'See https://pydantic-docs.helpmanual.io/usage/settings/#environment-variable-names',
+                        FutureWarning,
                     )
                 env_names = [cls.env_prefix + field.name]
             elif isinstance(env, str):
diff --git a/tests/test_settings.py b/tests/test_settings.py
@@ -208,7 +208,7 @@ class Settings(BaseSettings):
 
 
 def test_aliases_warning(env):
-    with pytest.warns(DeprecationWarning, match='aliases are no longer used by BaseSettings'):
+    with pytest.warns(FutureWarning, match='aliases are no longer used by BaseSettings'):
 
         class Settings(BaseSettings):
             foobar: str = 'default value'

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Use `FutureWarning` instead of `DeprecationWarning` when `alias` instead of `env` is used for settings models