8000 Add: added Seeed's Wio Terminal Board Support by ansonhex · Pull Request #3089 · adafruit/circuitpython · GitHub
[go: up one dir, main page]

Skip to content

Add: added Seeed's Wio Terminal Board Support #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Add: added Seeed's Wio Terminal Board Support #3089

merged 3 commits into from
Jun 30, 2020

Conversation

ansonhex
Copy link

Added Wio Terminal as board support.

@tannewt tannewt self-requested a review June 30, 2020 00:42
tannewt
tannewt previously approved these changes Jun 30, 2020
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge this.

Do you want to support the display at start up? Check out the PyPortal for an example. That way folks don't need to initialize the display themselves and output will show immediately on the screen. Feel free to open an issue or join Discord for help with that. Thanks!

@tannewt
Copy link
Member
tannewt commented Jun 30, 2020

Oops, I didn't see the tests failed. You'll want to add the board here: https://github.com/adafruit/circuitpython/blob/main/.github/workflows/build.yml#L242

That way it'll be built every commit and automatically released. Thanks!

@ansonhex
Copy link
Author

Hi @tannewt

I have added wio terminal here, not sure what is missing: https://github.com/ansonhe97/circuitpython/blob/main/.github/workflows/build.yml#L243

@ansonhex
Copy link
Author

For now, I have not seen an example with circuitpython using SPI LCD yet, may be you have some reference? That would be very helpful :D

@tannewt
Copy link
Member
tannewt commented Jun 30, 2020

Hi @tannewt

I have added wio terminal here, not sure what is missing: https://github.com/ansonhe97/circuitpython/blob/main/.github/workflows/build.yml#L243

The check is picky and wants it sorted. So wio before xiao.

@tannewt
Copy link
Member
tannewt commented Jun 30, 2020

For now, I have not seen an example with circuitpython using SPI LCD yet, may be you have some reference? That would be very helpful :D

Here is a SPI example: https://github.com/adafruit/circuitpython/blob/main/ports/atmel-samd/boards/pygamer/board.c#L73 What display IC controls the display? We may already have a board with the correct init sequence.

@ansonhex
Copy link
Author

Our LCD is ILI9341, any luck? :)

@ansonhex
Copy link
Author

Also there is a new CI error, what exactly is this and how can i fix this?

@tannewt
Copy link
Member
tannewt commented Jun 30, 2020

I don't think we have a board with it natively. I didn't do a great job documenting it in the board.c. The init sequence is here though: https://github.com/adafruit/Adafruit_CircuitPython_ILI9341/blob/master/adafruit_ili9341.py#L72

You'll just need to convert is to a C array.

@ansonhex
Copy link
Author

For now, can we simply use this driver:https://github.com/adafruit/Adafruit_CircuitPython_ILI9341 (will also test with wio terminal), may be we can add it later?

@tannewt
Copy link
Member
tannewt commented Jun 30, 2020

Yup! Will merge this now and a follow PR can add native display support. Testing from CircuitPython first is a good idea.

Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 74ad5e8 into adafruit:main Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0