8000 [3.x] Custom CSS For "Viewing Outdated Docs" Message by sommersoft · Pull Request #3073 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

[3.x] Custom CSS For "Viewing Outdated Docs" Message #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2020
Merged

[3.x] Custom CSS For "Viewing Outdated Docs" Message #3073

merged 2 commits into from
Jun 26, 2020

Conversation

sommersoft
Copy link

First step, and initial RTD test, of #3022. Obviously, will need to be accomplished with 2.x, 4.x, 5.x, and main after this one is ironed out.

I didn't include the JavaScript to close the message. I can try to work out how to do that with the RTD builds, but its hard to test local builds (the message doesn't pop up locally).

Will this require a 3.x release to kick RTD?

@sommersoft sommersoft requested a review from tannewt June 26, 2020 04:26
@sommersoft sommersoft changed the title Custom CSS For "Viewing Outdated Docs" Message [3.x] Custom CSS For "Viewing Outdated Docs" Message Jun 26, 2020
tannewt
tannewt approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It doesn't require a release RTD follows the branch.

@tannewt tannewt merged commit cf037a9 into adafruit:3.x Jun 26, 2020
@FoamyGuy
Copy link
Collaborator

This is working for me now on the 3.x live page. Looks great! Thank you sommersoft.
image

This was referenced Jun 26, 2020
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sommersoft @FoamyGuy @tannewt
0