forked from micropython/micropython
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
cached heap buffer for neopixel_write #2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#2449 crashes for me too. |
tannewt
reviewed
Feb 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One questions about realloc. Otherwise good!
Has run for over an hour, so it's looking solid. |
tannewt
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of @rhooper's #2449, with the same basic idea: allocate a heap buffer for
neopixel_write
when necessary, and save it for reuse. The last commit to #2449 was crashing; these further changes leave freeing the buffer to the garbage collector, and put the buffer into the root pointers.I ran @rhooper's Christmas tree code overnight with this on a shortened NeoPixel strip. It is still running 10 hours later.
@rhooper feel free to review too; I just can't add you as an official reviewer.
There is something wrong with #2449 for me: I can only see the PR if I am not logged in to GitHub. If I try to view it when logged in, I get a 500 Server Error. I've reported this to GitHub. Could someone else close that PR? Thanks.