8000 cached heap buffer for neopixel_write by dhalbert · Pull Request #2648 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

cached heap buffer for neopixel_write #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 22, 2020
Merged

cached heap buffer for neopixel_write #2648

merged 8 commits into from
Feb 22, 2020

Conversation

dhalbert
Copy link
Collaborator
@dhalbert dhalbert commented Feb 21, 2020 •
edited
Loading

This is a continuation of @rhooper's #2449, with the same basic idea: allocate a heap buffer for neopixel_write when necessary, and save it for reuse. The last commit to #2449 was crashing; these further changes leave freeing the buffer to the garbage collector, and put the buffer into the root pointers.

I ran @rhooper's Christmas tree code overnight with this on a shortened NeoPixel strip. It is still running 10 hours later.

@rhooper feel free to review too; I just can't add you as an official reviewer.

There is something wrong with #2449 for me: I can only see the PR if I am not logged in to GitHub. If I try to view it when logged in, I get a 500 Server Error. I've reported this to GitHub. Could someone else close that PR? Thanks.

@dhalbert dhalbert requested review from tannewt and kattni February 21, 2020 13:57
@tannewt
Copy link
Member
tannewt commented Feb 21, 2020

#2449 crashes for me too.

tannewt
tannewt reviewed Feb 21, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One questions about realloc. Otherwise good!

@dhalbert
Copy link
Collaborator Author

I pushed the realloc changes, and @rhooper and I are testing. @tannewt I'll request a re-review after some extended testing runs.

@dhalbert dhalbert requested a review from tannewt February 22, 2020 00:27
@dhalbert
Copy link
Collaborator Author

Has run for over an hour, so it's looking solid.

tannewt
tannewt approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@tannewt tannewt merged commit bd9572c into adafruit:master Feb 22, 2020
@dhalbert dhalbert mentioned this pull request Feb 22, 2020
Closed
@dhalbert dhalbert deleted the malloc-nrf-neopixel-write branch February 29, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@kattni kattni Awaiting requested review from kattni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @tannewt @rhooper
0