8000 Check sequence multiply for length overflow by tannewt · Pull Request #1520 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Check sequence multiply for length overflow #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2019
Merged

Check sequence multiply for length overflow #1520

merged 3 commits into from
Feb 5, 2019

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Feb 4, 2019

Fixes #1279

@tannewt tannewt added this to the 4.0.0 - Bluetooth milestone Feb 4, 2019
@tannewt tannewt requested review from kattni and sommersoft February 5, 2019 03:33
sommersoft
sommersoft reviewed Feb 5, 2019
View reviewed changes
Copy link
@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait; didn't realize you requested the review. Only a question.

Looks good to me, otherwise. Hooray for staying in bounds! 🎉

ports/atmel-samd/mpconfigport.h
@@ -54,6 +54,7 @@
#define MICROPY_PY_DESCRIPTORS (1)
#define MICROPY_PY_MATH (0)
#define MICROPY_PY_CMATH (0)
#define MICROPY_PY_MICROPYTHON_MEM_INFO (0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to disable across the port, or only for M0? Granted, I imagine few people utilize the full stack info...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the port to minimize inconsistencies. Hopefully the livestream helped show the alternative ways to debug.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@tannewt tannewt merged commit 041a84e into adafruit:master Feb 5, 2019
@tannewt
Copy link
Member Author
tannewt commented Feb 5, 2019

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommersoft sommersoft sommersoft approved these changes

@kattni kattni Awaiting requested review from kattni

Assignees
No one assigned
Labels
bug crash
Projects
None yet
Milestone
4.0.0 - Bluetooth
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @kevinjwalters @sommersoft
0