i2ctarget: Add deinit() to I2CTargetRequest; remove close() #10366
Conversation
17e24b8 to
7d3dd30
Compare
|
The following test code triggers the issue in 9.2.7 and works as expected with this PR. Controller code (running on a tiny2350) import board
import random
import time
from adafruit_bus_device.i2c_device import I2CDevice
i2c = board.STEMMA_I2C()
device = I2CDevice(i2c, 0x40)
buffer = bytearray(1)
while True:
try:
with device:
device.readinto(buffer)
print(f"device responded with #{buffer[0]:02X}")
time.sleep(1)
with device:
buffer[0] = random.randint(0, 255)
device.write(buffer)
print(f"wrote to device: #{buffer[0]:02X}")
time.sleep(1)
except OSError: # target resetting or in error
time.sleep(1)Target code (pro micro 2040) - that's the code being tested. import board
from i2ctarget import I2CTarget
memory = 0x55
with I2CTarget(board.SCL, board.SDA, (0x40,)) as device:
while True:
i2c_target_request = device.request()
if not i2c_target_request:
continue
with i2c_target_request:
if i2c_target_request.is_read:
print(f"read request: #{memory:02X}")
buffer = memory.to_bytes(1)
i2c_target_request.write(buffer)
else:
data = i2c_target_request.read(1)
print(f"write request: #{data[0]:02X}")
memory = data[0]Could we have the call to |
I considered that, but wasn't sure if there was another use case. But I think not. I'll do that, yes, thanks. |
7306e5e to
8da8e31
Compare
|
I will open a separate issue to fix the example. |
Removes visible
I2CTargetRequest.close()method. AddsI2CTargetRequest.deinit(). Doesclose()anddeinit()inI2CTargetRequest.__exit__(). MakesI2CTargetRequesthave a finalizer:__del__()callsdeinit().I tried testing with the more extensive example in the
I2CTargetdocumentation, which tries to write and then read a value to an I2C register. It did not work, but I could not get that example to work with 8.2.9 or 9.2.3 either.@Neradoc if you or someone else would like to test this with some previously-working code, I would be grateful.