-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Unable to connect to api.github.com #8910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here is the MBEDTLS log. I'm not sure why it is failing. Maybe outgoing buffer size?
|
Just a note that "%zu" is intended to print a value of type size_t but this is not supported and so just "zu" is printed. "I (265634) mbedtls: ssl_msg.c:2312 in_left: zu, nb_want: zu" This problem almost certainly stems from the hacky way I connect esp-idf's debug printing to use circuitpython's printf implementation:
|
Ya, that seemed suspect to me. I'll fix it now and see what I get. |
could try hacking in %z support. diff --git a/py/mpprint.c b/py/mpprint.c
index 467371bec2..5bc920bb62 100644
--- a/py/mpprint.c
+++ b/py/mpprint.c
@@ -464,7 +464,7 @@ int mp_vprintf(const mp_print_t *print, const char *fmt, va_list args) {
const
#endif
bool long_arg = false;
- if (*fmt == 'l') {
+ if (*fmt == 'l' || *fmt == 'z') {
++fmt;
#ifdef __LP64__
long_arg = true; |
I checked the commit for |
I updated the test list to:
And |
I'm at a loss. It looks like the server is resetting the connection after we send the client key:
|
Is it possible to compare to |
[CORRECTED] Confirmed that 9.0.0-alpha.6 fails and 9.0.0-alpha.5 succeeds, so we can do a bisect in that range. Tested on both ESP32-S2 and ESP32-S3. Both show this behavior. |
@dhalbert that 5 fails and 6 succeeds, or the other way around? I had 5 being successful... Also the other strange part was how much slower it was vs 8.2.9 |
Sorry that was my late-night error. Fixed. |
ugh 5.1 -> 5.1.2: |
I'm getting this to work by adjusting the MBEDTLS_ECP settings. Will have a PR later. |
the mbedtls version is a bit different so there are some new #ifdefs needed. Tested with the ssl test from adafruit#8910 on Adafruit MatrixPortal S3 (no pico w testing done)
CircuitPython version
Code/REPL
Behavior
Added some print statements to
adafruit_requests
:Description
On a ESP32S3 chip will fail with
OSError: Failed SSL handshake
when trying tosocket.connect
toapi.github.com
8.2.9
: works every time. Average time ~5 seconds9.0.0-alpha.2.uf2
: happens half the time: Average time ~15 seconds9.0.0-alpha.4.uf2
:MemoryError: memory allocation failed, allocating 1784 bytes
on line 79.0.0-alpha.5.uf2
: never errored: Average time ~12 seconds9.0.0-alpha.6.uf2
: always errored: Average time ~20 seconds9.0.0-beta.0
: always errored: Average time ~20 seconds9.0.0-beta.0 from PR merge 8898
: always errored: Average time ~20 secondsAdditional information
No response
The text was updated successfully, but these errors were encountered: