8000 pio: clean up FIFO-stuffing code · Issue #4162 · adafruit/circuitpython · GitHub
[go: up one dir, main page]

Skip to content
pio: clean up FIFO-stuffing code #4162
Closed
@jepler

Description

@jepler

@tannewt [observed](https://github.com/adafruit/circuitpython/pull/4155#pullrequestreview-586038240}:

I think it'd be clearer if you replaced the original if statements with while loops. That way you'd load up the 4 or 8 entry FIFO and then move on. 32 seems arbitrary and I'm skeptical you'd ever hit that many due to the FIFO size.

Just in case I don't get to this during some upcoming PIO work, I wanted it filed in an issue instead of in the review comments of a closed PR!

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0