Report OSErrors in a more human-readable way #221

dhalbert · 2017-08-31T23:44:59Z

>>> import os
>>> os.mkdir("foo34")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: 30
>>> os.rename("main.py", "foo.py")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: 30

It would be better to give some indication that the filesystem was read-only instead of a numeric error.

The text was updated successfully, but these errors were encountered:

tannewt · 2017-09-01T18:39:49Z

Here is what CPython 3.6 does in the REPL and what we should mimic.

>>> import os
>>> os.mkdir("/Volumes/Untitled/test")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 30] Read-only file system: '/Volumes/Untitled/test'

Here are the relevant properties on it:

>>> error.errno
30
>>> error.strerror
'Read-only file system'
>>> error.filename
'/Volumes/Untitled/test'

dhalbert · 2017-09-01T21:11:04Z

Revising title: on atmel-samd, all errors are reported only numerically. On esp8266 and unix, the errno name is given as well. As @tannewt shows above, both could be better.

This has to do with whether MICROPY_PY_UERRNO is enabled or not.

>>> os.listdir("main.py")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: 2

esp8266 and unix ports:

>>> os.listdir("boot.py")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OSError: [Errno 2] ENOENT

Sigafoos · 2017-09-12T22:40:27Z

This may be a separate issue, but OSError doesn't seem to have some of the attributes the CPython docs says it does:

This exception is derived from EnvironmentError. It is raised when a function returns a system-related error (not for illegal argument types or other incidental errors). The errno attribute is a numeric error code from errno, and the strerror attribute is the corresponding string, as would be printed by the C function perror(). See the module errno, which contains names for the error codes defined by the underlying operating system.

For exceptions that involve a file system path (such as chdir() or unlink()), the exception instance will contain a third attribute, filename, which is the file name passed to the function.

>>> try:
...     fp = open("/x", "a")
... except OSError as e:
...     v = e
...
>>> v.args[0]
30
>>> v.errno
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'OSError' object has no attribute 'errno'
>>> v.strerror
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'OSError' object has no attribute 'strerror'

process1183 · 2017-10-20T00:15:42Z

This is something I would like to work on.

godlygeek · 2018-05-14T15:03:43Z

I'm going to take a swing at this one.

godlygeek · 2018-05-15T20:26:10Z

#837 mostly fixes this, though I still want to take a look and see if we can improve the situation for Gemma's and other boards with little flash...

rhooper · 2018-05-15T20:52:57Z

There will now a bit more flash available on gemma_m0 and trinket_m0 once my PR is merged, if that'll help?

tannewt · 2018-05-17T17:21:50Z

Fixed by #837. Thanks @godlygeek and @rhooper for making space.

dhalbert changed the title ~~atmel-samd: os file operations that would write give error 30~~ Report OSErrors in a more human-readable way Sep 1, 2017

tannewt added this to the 3.0 milestone Sep 6, 2017

tannewt assigned process1183 Oct 20, 2017

tannewt added the enhancement label Jan 16, 2018

tannewt unassigned process1183 Feb 13, 2018

61ED tannewt closed this as completed May 17, 2018

Gigahawk mentioned this issue Nov 23, 2018

Human readable OSErrors should include 30 and 28 #1352

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Report OSErrors in a more human-readable way #221

Report OSErrors in a more human-readable way #221

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Report OSErrors in a more human-readable way #221

Report OSErrors in a more human-readable way #221

Comments

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!