From c9d03ff186ceb743ce8c1a750b6453c30a8923cd Mon Sep 17 00:00:00 2001 From: Mikey Sklar Date: Wed, 11 Sep 2024 12:01:11 -0700 Subject: [PATCH 1/2] alarm2 changes ds3231: minute support status frequency re-order --- adafruit_register/i2c_bcd_alarm.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/adafruit_register/i2c_bcd_alarm.py b/adafruit_register/i2c_bcd_alarm.py index 4f18cbc..04f0692 100644 --- a/adafruit_register/i2c_bcd_alarm.py +++ b/adafruit_register/i2c_bcd_alarm.py @@ -23,7 +23,7 @@ from circuitpython_typing.device_drivers import I2CDeviceDriver FREQUENCY_T = Literal[ - "monthly", "weekly", "daily", "hourly", "secondly", "minutely" + "monthly", "weekly", "daily", "hourly", "minutely", "secondly" ] except ImportError: pass @@ -115,6 +115,9 @@ def __get__( frequency = "minutely" seconds = _bcd2bin(self.buffer[1] & 0x7F) i = 2 + else: + frequency = "minutely" + seconds = _bcd2bin(self.buffer[i] & 0x7F) minute = 0 if (self.buffer[i] & 0x80) == 0: frequency = "hourly" @@ -169,7 +172,7 @@ def __set__( raise ValueError(error_message) frequency = FREQUENCY.index(frequency_name) - if frequency <= 1 and not self.has_seconds: + if frequency < 1 and not self.has_seconds: raise ValueError(error_message) # i is the index of the minute byte From 531bc36fcee4c39319c69254ce375e71cdc35898 Mon Sep 17 00:00:00 2001 From: Mikey Sklar Date: Wed, 11 Sep 2024 12:27:27 -0700 Subject: [PATCH 2/2] disable too-many-branches more obvious to add an additional else than to get cray cray and make the logic truly unreadable. --- adafruit_register/i2c_bcd_alarm.py | 1 + 1 file changed, 1 insertion(+) diff --git a/adafruit_register/i2c_bcd_alarm.py b/adafruit_register/i2c_bcd_alarm.py index 04f0692..74c8a77 100644 --- a/adafruit_register/i2c_bcd_alarm.py +++ b/adafruit_register/i2c_bcd_alarm.py @@ -2,6 +2,7 @@ # # SPDX-License-Identifier: MIT # pylint: disable=too-few-public-methods +# pylint: disable=too-many-branches """ `adafruit_register.i2c_bcd_alarm`