8000 pystack and other errors by justmobilize · Pull Request #218 · adafruit/Adafruit_CircuitPython_MiniMQTT · GitHub
[go: up one dir, main page]
Skip to content

pystack and other errors #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

pystack and other errors #218

merged 1 commit into from
May 22, 2024

Conversation

justmobilize
Copy link
Collaborator
@justmobilize justmobilize commented May 22, 2024 •
edited
Loading

This PR fixes a few things (although the changes are tiny):

fixes #215
After pystack limit reached, MQTT service continues retry until timeout
Added a catch for the RuntimeError: pystack exhaustet to stop retrying

This also fixes adafruit/Adafruit_CircuitPython_AWS_IOT#23
AWS_IOT_ERROR ('Error Connection to AWS IoT: ', MQTTException('Repeated connect failures',))

fixes #214
generic timeout error when 'is_ssl' param not set for an mqtt service that requires it
This is fixed also by adafruit/circuitpython#9266
Together these provide better errors so the use knows what's happening

@justmobilize justmobilize marked this pull request as ready for review May 22, 2024 00:48
@justmobilize
Copy link
Collaborator Author

@dhalbert some tiny error handling updates

@dhalbert dhalbert self-requested a review May 22, 2024 02:13
dhalbert
dhalbert reviewed May 22, 2024
View reviewed changes
Copy link
Contributor
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know of certain RuntimeError exceptions that should be retried? I am just wondering if they should all just be raised.

@justmobilize
Copy link
Collaborator Author

I don't 8000 know of any that should be, but I'm still trying to learn all of the different errors across the chips...

dhalbert
dhalbert approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll add this now. If it needs to generalized later that's ok.

@dhalbert dhalbert merged commit f871143 into adafruit:main May 22, 2024
1 check passed
@justmobilize justmobilize deleted the pystack-and-other-errors branch May 22, 2024 17:25
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request May 23, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c89a027)
6c24b5b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.9.0 from 7.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#218 from justmobilize/pystack-and-other-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@justmobilize @dhalbert
0