8000 Brought docs example into parity with actual example, removed unused code lines. by mfeif · Pull Request #33 · adafruit/Adafruit_CircuitPython_IRRemote · GitHub
[go: up one dir, main page]

Skip to content

Brought docs example into parity with actual example, removed unused code lines. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

mfeif
Copy link
Contributor
@mfeif mfeif commented Mar 3, 2020

The example files themselves work, but if one copied the code from README.rst, it would crash. This brings the docs to be the same as the actual code provided.

Also, I removed some python that wasn't actually doing anything, and thus might confuse people.

@mfeif mfeif mentioned this pull request Mar 3, 2020
Copy link
Contributor
@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking into this and updating the readme. These changes look good to me. However I'm not certain about these removed lines:

# size must match what you are decoding! for NEC use 4
received_code = bytearray(4)

As far as I can tell these were introduced with this commit and never seem to have gotten used anywhere that I could find. @sommersoft or @tannewt either of know if it's meant to be used only in a certain situation? Or if it's okay to get rid of them?

@tannewt
Copy link
Member
tannewt commented Mar 4, 2020

@FoamyGuy It's ok to get rid of. Probably just leftovers from more complicated code.

@FoamyGuy FoamyGuy merged commit 3a90410 into adafruit:master Mar 4, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 5, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#66 from FoamyGuy/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.4.2 from 3.4.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#33 from mfeif/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.0.0 from 5.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#72 from tannewt/remove_radio

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#21 from jimbobbennett/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0