Brought docs example into parity with actual example, removed unused code lines. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
FoamyGuy
reviewed
Mar 4, 2020
There was a problem hiding this comment.
Thank you for checking into this and updating the readme. These changes look good to me. However I'm not certain about these removed lines:
# size must match what you are decoding! for NEC use 4
received_code = bytearray(4)
As far as I can tell these were introduced with this commit and never seem to have gotten used anywhere that I could find. @sommersoft or @tannewt either of know if it's meant to be used only in a certain situation? Or if it's okay to get rid of them?
|
@FoamyGuy It's ok to get rid of. Probably just leftovers from more complicated code. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 5, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 3.2.3 from 3.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#66 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 3.4.2 from 3.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#33 from mfeif/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.0.0 from 5.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#72 from tannewt/remove_radio Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.3.0 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#21 from jimbobbennett/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example files themselves work, but if one copied the code from README.rst, it would crash. This brings the docs to be the same as the actual code provided.
Also, I removed some python that wasn't actually doing anything, and thus might confuse people.