support bleak 0.19.0 and up #58
Conversation
|
@tekktrik This library is like I changed it to your composite actions for this PR so the build did not fail, but I wonder what the right thing to do here is. The Blinka library is not a great example here because it doesn't even use Also tagging @makermelissa here for ideas |
|
I think the composite actions are great for the many libraries that will always use the same build process because it also ensures that they're updated consistently and simultaneously. Since that may actually not be the desired effect here, I don't think it's wrong to have custom CI workflows for libraries like this. With those composite actions it means that doing these ones manually is much more feasible. Alternatively we could make it possible for the composite actions to not build the bundle, but I think the aforementioned solution is better. Another option is to break out the composite actions further into smaller puzzle pieces that can be used here, but I think that might result in a lot of very small pieces of workflow code that could be just as hard to manage as just manually patching repos like this one. |
|
@tekktrik Thanks for the comments. I have restored the original workflow files and removed unnecessary steps from it. |
The
bleakversion was pinned to 0.11.0 in the early days of this library, whenbleakwas undergoing a lot of API churn. That may have also prevented advancing the supported Python version (the guide recommended Python 3.8). There have been many changes, fixes, and improvements tobleaksince then. As an example, the Windows backend now uses a different lower-level lirbrary.Updated to handle API changes in
bleakfrom 0.19.0 on.Tested using
adafruit_ble_heart_ratewithbleak0.20.1, on Linux, macoS 13.2.1 and 13.3, Windows 10, and Windows 11, with Python 3.10.x and 3.11.x. Works on all, except that on Windows, the default timeout forBLERadio.connect(), which is 4 seconds seems to be too short at least some of the time. I increased it to 10 seconds and it connects successfully. Once it has connected once, further connects are faster. I may change the timeout there after this is released; at the very least I will document the issue in the Learn Guide, https://learn.adafruit.com/circuitpython-ble-libraries-on-any-computer.EDIT: Tested on latest RPI bullseye as well. Works, after lengthening connection timeout to 10 seconds, as I had to do for Windows. This confirms it's a good idea to change the default.
Fixes #41.
Fixes #45.