Example for replace_url

bbayles · anonrig · commit 8556476fb49c · 2023-05-17T22:05:24.000-04:00
diff --git a/README.rst b/README.rst
@@ -45,3 +45,5 @@ It also provides some higher level functions for parsing and manipulating URLs.
         'search': '?q=1',
         'hash': '#2'
     }
+    >>> ada_url.replace_url('http://example.org:80', protocol='https:')
+    'https://example.org/'
diff --git a/ada_url/ada_adapter.py b/ada_url/ada_adapter.py
@@ -304,7 +304,7 @@ def replace_url(s, **kwargs):
 
         for attr in URL_ATTRIBUTES:
             value = kwargs.get(attr)
-            if not value:
+            if value is None:
                 continue
 
             try:
diff --git a/tests/test_ada_url.py b/tests/test_ada_url.py
@@ -242,6 +242,12 @@ def test_replace_url(self):
                 actual = replace_url(s, **kwargs)
                 self.assertEqual(actual, expected)
 
+    def test_replace_blank(self):
+        s = 'https://user:pass@example.org'
+        actual = replace_url(s, username='', password='')
+        expected = 'https://example.org/'
+        self.assertEqual(actual, expected)
+
     def test_replace_href(self):
         s = 'https://username:password@www.google.com:8080/'
         kwargs = {

Original file line number	Diff line number	Diff line change
`@@ -45,3 +45,5 @@ It also provides some higher level functions for parsing and manipulating URLs.`
`45`	`45`	`'search': '?q=1',`
`46`	`46`	`'hash': '#2'`
`47`	`47`	`}`
	`48`	`+ >>> ada_url.replace_url('http://example.org:80', protocol='https:')`
	`49`	`+ 'https://example.org/'`