8000 Improve accessibility with better color contrast by tagliala · Pull Request #8535 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Improve accessibility with better color contrast #8535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve accessibility with better color contrast #8535

wants to merge 1 commit into from

Conversation

tagliala
Copy link
Contributor
@tagliala tagliala commented Nov 5, 2024 •
edited
Loading

Fixes Lighthouse accessibility violations, particularly for form hint text that was difficult to read in dark mode.

  • Make extra-small text darker in both light and dark themes for better readability
  • Adjust dark theme colors to better work with non-black background:
    • Change some text color from 500 to 400
    • Update link color from blue-600 to blue-500

Before vs After

Form (dark)

image
image

Comment (light)

image
image

Comment (dark)

image
image

Footer (dark)

image
image

@codecov Codecov
Copy link
codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (ab49cb8) to head (7514b11).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8535   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4073     4073           
=======================================
  Hits         4037     4037           
  Misses         36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala
Improve accessibility with better color contrast
7514b11 
Fixes Lighthouse accessibility violations, particularly for form hint
text that was difficult to read in dark mode.

- Make extra-small text darker in both light and dark themes for better
  readability
- Adjust dark theme colors to better work with non-black background:
  - Change some text color from 500 to 400
  - Update link color from `blue-600` to `blue-500`
@tagliala tagliala force-pushed the chore/improve-text-contrast-ratio branch from 5e126e2 to 7514b11 Compare January 8, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tagliala
0