activeadmin · javierjulio · Jul 10, 2019 · Jul 10, 2019
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -79,6 +79,9 @@ Style/FrozenStringLiteralComment:
 Style/HashSyntax:
   Enabled: true
 
+Style/ParallelAssignment:
+  Enabled: true
+
 Layout/IndentationConsistency:
   Enabled: true
 

diff --git a/features/step_definitions/batch_action_steps.rb b/features/step_definitions/batch_action_steps.rb
@@ -35,7 +35,8 @@
   page.find("#batch_action", visible: false).set action
   form   = page.find "#collection_selection"
   params = page.all("#main_content input", visible: false).each_with_object({}) do |input, obj|
-    key, value = input['name'], input['value']
+    key = input['name']
+    value = input['value']
     if key == 'collection_selection[]'
       (obj[key] ||= []).push value if input.checked?
     else

diff --git a/lib/active_admin/batch_actions/resource_extension.rb b/lib/active_admin/batch_actions/resource_extension.rb
@@ -112,7 +112,11 @@ class BatchAction
     # => You can pass a hash of options to `:form` that will be rendered as form input fields for the user to fill out.
     #
     def initialize(sym, title, options = {}, &block)
-      @sym, @title, @options, @block, @confirm = sym, title, options, block, options[:confirm]
+      @sym = sym
+      @title = title
+      @options = options
+      @block = block
+      @confirm = options[:confirm]
       @block ||= proc {}
     end
 

diff --git a/lib/active_admin/controller_action.rb b/lib/active_admin/controller_action.rb
@@ -2,7 +2,8 @@ module ActiveAdmin
   class ControllerAction
     attr_reader :name
     def initialize(name, options = {})
-      @name, @options = name, options
+      @name = name
+      @options = options
     end
 
     def http_verb

diff --git a/lib/active_admin/csv_builder.rb b/lib/active_admin/csv_builder.rb
@@ -32,7 +32,9 @@ def self.default_for_resource(resource)
 
     def initialize(options = {}, &block)
       @resource = options.delete(:resource)
-      @columns, @options, @block = [], options, block
+      @columns = []
+      @options = options
+      @block = block
     end
 
     def column(name, options = {}, &block)

diff --git a/lib/active_admin/error.rb b/lib/active_admin/error.rb
@@ -6,7 +6,9 @@ class AccessDenied < StandardError
     attr_reader :user, :action, :subject
 
     def initialize(user, action, subject = nil)
-      @user, @action, @subject = user, action, subject
+      @user = user
+      @action = action
+      @subject = subject
 
       super()
     end

diff --git a/lib/active_admin/page_presenter.rb b/lib/active_admin/page_presenter.rb
@@ -21,7 +21,8 @@ class PagePresenter
     delegate :has_key?, :fetch, to: :options
 
     def initialize(options = {}, &block)
-      @options, @block = options, block
+      @options = options
+      @block = block
     end
 
     def [](key)

diff --git a/lib/active_admin/resource.rb b/lib/active_admin/resource.rb
@@ -71,7 +71,8 @@ def initialize(namespace, resource_class, options = {})
         @resource_class_name = "::#{resource_class.name}"
         @options    = options
         @sort_order = options[:sort_order]
-        @member_actions, @collection_actions = [], []
+        @member_actions = []
+        @collection_actions = []
       end
     end
 

diff --git a/lib/active_admin/resource/belongs_to.rb b/lib/active_admin/resource/belongs_to.rb
@@ -15,7 +15,9 @@ def initialize(key, namespace)
       attr_reader :owner
 
       def initialize(owner, target_name, options = {})
-        @owner, @target_name, @options = owner, target_name, options
+        @owner = owner
+        @target_name = target_name
+        @options = options
       end
 
       # Returns the target resource class or raises an exception if it doesn't exist

diff --git a/lib/active_admin/router.rb b/lib/active_admin/router.rb
@@ -4,7 +4,8 @@ class Router
     attr_reader :namespaces, :router
 
     def initialize(router:, namespaces:)
-      @router, @namespaces = router, namespaces
+      @router = router
+      @namespaces = namespaces
     end
 
     def apply

diff --git a/lib/active_admin/scope.rb b/lib/active_admin/scope.rb
@@ -28,7 +28,8 @@ class Scope
     #   # => Scope with the group :status
     #
     def initialize(name, method = nil, options = {}, &block)
-      @name, @scope_method = name, method.try(:to_sym)
+      @name = name
+      @scope_method = method.try(:to_sym)
 
       if name.is_a? Proc
         raise "A string/symbol is required as the second argument if your label is a proc." unless method
@@ -38,8 +39,11 @@ def initialize(name, method = nil, options = {}, &block)
         @id = name.to_s.parameterize(separator: "_")
       end
 
-      @scope_method               = nil        if @scope_method == :all
-      @scope_method, @scope_block = nil, block if block_given?
+      @scope_method = nil if @scope_method == :all
+      if block_given?
+        @scope_method = nil
+        @scope_block = block
+      end
 
       @localizer        = options[:localizer]
       @show_count       = options.fetch(:show_count, true)

diff --git a/lib/active_admin/sidebar_section.rb b/lib/active_admin/sidebar_section.rb
@@ -6,7 +6,9 @@ class SidebarSection
     attr_accessor :name, :options, :block
 
     def initialize(name, options = {}, &block)
-      @name, @options, @block = name.to_s, options, block
+      @name = name.to_s
+      @options = options
+      @block = block
       normalize_display_options!
     end
 

diff --git a/lib/active_admin/view_helpers/display_helper.rb b/lib/active_admin/view_helpers/display_helper.rb
@@ -3,7 +3,8 @@ module ViewHelpers
     module DisplayHelper
 
       DISPLAY_NAME_FALLBACK = -> {
-        name, klass = "", self.class
+        name = ""
+        klass = self.class
         name << klass.model_name.human         if klass.respond_to? :model_name
         name << " ##{send(klass.primary_key)}" if klass.respond_to? :primary_key
         name.present? ? name : to_s