8000 active_admin.scss generated even when no SASS support is present · Issue #8562 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

active_admin.scss generated even when no SASS support is present #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
giuseb opened this issue Dec 2, 2024 · 3 comments
Closed

active_admin.scss generated even when no SASS support is present #8562

giuseb opened this issue Dec 2, 2024 · 3 comments

Comments

@giuseb
Copy link
Contributor
giuseb commented Dec 2, 2024

Upon generating a new Rails 8 app:

rails new aademo
cd aademo
bundle add devise
bundle add activeadmin  --version "4.0.0.beta14"
rails g active_admin:install User

the file app/assets/stylesheets/active_admin.scss is generated, as also stated here, despite the lack of SASS support in this new app.

I understand that the v3 → v4 upgrade guide addresses the css management strategy, but from the perspective of a new user, this is puzzling.
@tagliala
Copy link
Contributor
tagliala commented Dec 2, 2024

Hi,

I understand that the v3 → v4 upgrade guide addresses the css management strategy, but from the perspective of a new user, this is puzzling.

This is being discussed here: #8538 and there is a PR with better instructions for a new application at #8545

Feel free to provide feedback on the new PR

There should be also a way to install active admin without a build, discussed somewhere in the discussions

@javierjulio
Copy link
Member

@giuseb sorry, this is not reproducible. As part of the v4 beta, I made sure to delete the SCSS file but that's intended if upgrading from v3. Since you did this as a fresh install it won't even exist since v4 doesn't generate that file although it will still delete it as shown by the command output.

    generate  active_admin:assets
       rails  generate active_admin:assets 
      remove  app/assets/stylesheets/active_admin.scss
      remove  app/assets/javascripts/active_admin.js
      create  app/assets/stylesheets/active_admin.css
      create  tailwind-active_admin.config.js

> ls app/assets/stylesheets
active_admin.css
application.css

If you are able to provide a reproduction, let us know. Thank you.

@giuseb
Copy link
Contributor Author
giuseb commented Dec 5, 2024

I do apologize for wasting your time.
I was also unable to reproduce the circumstance; I must have originally bundled the v3 gem by mistake.
Sorry again and thank you for the good work.
Giuseppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giuseb @javierjulio @tagliala
0