8000 Feature Request: Allow Application-wide disabling of pagination total · Issue #5405 · activeadmin/activeadmin · GitHub
[go: up one dir, main page]
Skip to content

Feature Request: Allow Application-wide disabling of pagination total #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knightstick opened this issue May 3, 2018 · 1 comment
Closed

Feature Request: Allow Application-wide disabling of pagination total #5405

knightstick opened this issue May 3, 2018 · 1 comment

Comments

@knightstick
Copy link
knightstick commented May 3, 2018 •
edited
Loading

We have ActiveAdmin running with a large database, where, many of the resources should have the pagination_total: false, otherwise our requests will time out.

It would be nice for us to set some application-wide config disallowing the pagination by default, and only allowing where specifically required.

I'm happy to take on this feature with a bit of guidance!

This appears to be the line in question:

activeadmin/lib/active_admin/views/components/paginated_collection.rb

Line 45 in fdef557

@display_total = options.delete(:pagination_total) { true }

It should be possible to check the config in the default block.
@giubueno
Copy link
giubueno commented May 9, 2018

Have you checked this PR? #5389

@javierjulio javierjulio closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javierjulio @giubueno @knightstick
0