Replies: 4 comments 2 replies
-
|
Refs: Hi, please wait for a confirmation but I think that using |
Beta Was this translation helpful? Give feedback.
-
|
I like the idea of using I did a quick test and using Just note that |
Beta Was this translation helpful? Give feedback.
-
|
Here's a draft solution that incorporates suggestions from @mgrunberg: #8439 |
Beta Was this translation helpful? Give feedback.
-
|
@amiel thank you again. The change looks good but we want to add a conditional so the older method is only used if running Rails 6.1, otherwise always use the current |
Beta Was this translation helpful? Give feedback.
-
|
That makes sense. I'll do that now. |
Beta Was this translation helpful? Give feedback.
-
|
Thank you everyone for the input. Any continued discussion can happen in #8439. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Currently (in both v4 and v3), html attributes passed to the
f.inputsblock in theformsection of a resource, are rendered usinghtml_options.map { |k, v| %Q{#{k}="#{v}"} }.join(" ").This results in a different behavior from other places that take html attributes. For example:
This can easily be resolved by using the Rails
tag.attributeshelper. For example, the following change is working well for me.As per the contributing guidelines, I'm opening this discussion to see if there's any interest in this fix (I'm happy to write up a PR).
I'm also wondering if there's any willingness to backport a fix like this to v3.
Thank you so much for your consideration!
Beta Was this translation helpful? Give feedback.
All reactions