run update_resource inside a transaction to avoid autosaving relationships through assign_attributes when the record is invalid

javierjulio · mgrunberg · commit a12c20378a0f · 2024-09-26T18:28:18.000-03:00
diff --git a/app/controllers/active_admin/resource_controller/data_access.rb b/app/controllers/active_admin/resource_controller/data_access.rb
@@ -168,11 +168,16 @@ def save_resource(object)
       #
       # @return [void]
       def update_resource(object, attributes)
-        object = assign_attributes(object, attributes)
+        status = nil
+        ActiveRecord::Base.transaction do
+          object = assign_attributes(object, attributes)
 
-        run_update_callbacks object do
-          save_resource(object)
+          run_update_callbacks object do
+            status = save_resource(object)
+            raise ActiveRecord::Rollback unless status
+          end
         end
+        status
       end
 
       # Destroys an object from the database and calls appropriate callbacks.
