Improve rendering attributes for f.inputs

amiel · amiel · commit 86aa14ad26f5 · 2024-08-20T17:09:25.000-07:00
diff --git a/lib/active_admin/views/components/active_admin_form.rb b/lib/active_admin/views/components/active_admin_form.rb
@@ -132,7 +132,7 @@ def build(form_builder, *args, &block)
         legend = args.shift if args.first.is_a?(::String)
         legend = html_options.delete(:name) if html_options.key?(:name)
         legend_tag = legend ? "<legend class=\"fieldset-title\">#{ERB::Util.html_escape(legend)}</legend>" : ""
-        fieldset_attrs = html_options.map { |k, v| %Q{#{k}="#{v}"} }.join(" ")
+        fieldset_attrs = tag.attributes html_options
         @opening_tag = "<fieldset #{fieldset_attrs}>#{legend_tag}<ol>"
         @closing_tag = "</ol></fieldset>"
         super(*(args << html_options), &block)
diff --git a/spec/unit/form_builder_spec.rb b/spec/unit/form_builder_spec.rb
@@ -62,7 +62,7 @@ def build_form(options = {}, form_object = Post.new, &block)
     context "with custom settings" do
       let :body do
         build_form do |f|
-          f.inputs class: "custom_class", name: "custom_name", custom_attr: "custom_attr" do
+          f.inputs class: "custom_class", name: "custom_name", custom_attr: "custom_attr", data: { test: "custom" } do
             f.input :title
             f.input :body
           end
@@ -80,6 +80,10 @@ def build_form(options = {}, form_object = Post.new, &block)
       it "should generate a fieldset with a custom attributes" do
         expect(body).to have_css("fieldset[custom_attr='custom_attr']")
       end
+
+      it "should use the rails helper for rendering attributes" do
+        expect(body).to have_css("fieldset[data-test='custom']")
+      end
     end
 
     context "with XSS payload as name" do
