Enhance readability of .python-version #1105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the readability and functionality when reading the .python-version file by supporting multiple versions, handling pyenv-virtualenv pointers, ignoring comments and empty lines, and trimming whitespace.
- Updated the function name and logic in utils.ts to process multiple lines.
- Refactored setup-python.ts and updated tests in tests/utils.test.ts to integrate the new behavior.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils.ts | Renamed and updated function to support multi-line version files and pointer handling. |
| src/setup-python.ts | Updated import and usage to reflect the new function name. |
| tests/utils.test.ts | Added tests for multi-line files and updated expected outcomes. |
Comment on lines
+284
to
+287
| if (line.startsWith('#') || line.trim() === '') { | ||
| return undefined; | ||
| } | ||
| let version: string = line.trim(); |
There was a problem hiding this comment.
[nitpick] Consider caching the result of line.trim() in a variable to avoid calling trim() multiple times within the mapping function.
Suggested change
| if (line.startsWith('#') || line.trim() === '') { | |
| return undefined; | |
| } | |
| let version: string = line.trim(); | |
| const trimmedLine = line.trim(); | |
| if (line.startsWith('#') || trimmedLine === '') { | |
| return undefined; | |
| } | |
| let version: string = trimmedLine; |
Copilot uses AI. Check for mistakes.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance reading from .python-version file, matching the Pyenv behavior:
3.10/envs/virtualenv)(see Don't use
.python-versionfor auto-activation pyenv/pyenv-virtualenv#472)#We extend our thanks to @krystof-k for the valuable contribution in implementing this feature in PR #787. To 8000 expedite its availability to users, we have created this PR, which incorporates the same changes while addressing the CI issues that had previously delayed the merge of PR #787.
Check list: