8000 Poetry virtualenv is not created when the project is not in the repository's root · Issue #539 · actions/setup-python · GitHub
[go: up one dir, main page]
Skip to content

Poetry virtualenv is not created when the project is not in the repository's root #539

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
5 tasks done
elilutsky opened this issue Nov 12, 2022 · 4 comments
Closed
5 tasks done

Poetry virtualenv is not created when the project is not in the repository's root #539

elilutsky opened this issue Nov 12, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@elilutsky
Copy link
elilutsky commented Nov 12, 2022 •
edited
Loading

Description:
poetry env use is run in the repository's root, causing it to fail since no pyproject.toml is present.

setup-python/src/cache-distributions/poetry-cache.ts

Lines 37 to 44 in 47c4a7a

const {
exitCode,
stderr
} = await exec.getExecOutput(
`poetry env use ${pythonLocation}`,
undefined,
{ignoreReturnCode: true}
);

Currently, only a warning is being displayed:

image

Actually, this is solved by @oranav in #447.

Action version:
v4

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:
All poetry versions

Repro steps:
Create a repository with a Poetry project inside a subfolder and run the action.

Expected behavior:
Either fail hard or run env use on all Poetry projects inside the repository

Actual behavior:
Prints a warning
@elilutsky elilutsky added bug Something isn't working needs triage labels Nov 12, 2022
@MaksimZhukov
Copy link
Contributor

Hello @elilutsky! Thank you for reporting this!
We will investigate the issue and get back 8000 to you as soon as we have updates.

@oranav
Copy link
Contributor
oranav commented Nov 14, 2022

I think this is essentially a symptom of #446

@MaksimZhukov
Copy link
Contributor

Hello @elilutsky!
We've merged PR #447 and released v4.5.0 action version. Could please confirm that the issue has been fixed?

@MaksimZhukov
Copy link
Contributor

I am closing this issue. Please let us know if you have any objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oranav @elilutsky @MaksimZhukov
0