8000 Add newest PyPy 7.3.3 · Issue #163 · actions/setup-python · GitHub
[go: up one dir, main page]
Skip to content

Add newest PyPy 7.3.3 #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 of 7 tasks
hugovk opened this issue Nov 27, 2020 · 8 comments
Closed
4 of 7 tasks

Add newest PyPy 7.3.3 #163

hugovk opened this issue Nov 27, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@hugovk
Copy link
Contributor
hugovk commented Nov 27, 2020

Describe the bug
A clear and concise description of what the bug is.

GitHub Actions has PyPy 7.3.2.

The latest PyPy release is 7.3.3.

https://morepypy.blogspot.com/2020/11/pypy-733-triple-release-python-37-36.html

It contains a fix to allow us to test with tox:

Which version of the action are you using?

  • v1
  • v2
  • Some other tag (such as v2.0.1 or master)

Environment

  • self-hosted
  • Linux
  • Windows
  • Mac

If applicable, please specify if you're using a container

Python Versions
Please list all of the effected versions of Python (3.8.2, etc.)

pypy

To Reproduce
Steps to reproduce the behavior:

With a YAML something like this:

name: Test

on: [push, pull_request]

jobs:
  build:
    runs-on: ${{ matrix.os }}
    strategy:
      fail-fast: false
      matrix:
        python-version: [pypy, pypy3]
        os: [
          ubuntu-20.04,
          ubuntu-18.04,
          ubuntu-16.04,
          macOS-latest,
          windows-latest,
        ]

    steps:
      - uses: actions/checkout@v2

      - name: Set up Python ${{ matrix.python-version }}
        uses: actions/setup-python@v2
        with:
          python-version: ${{ matrix.python-version }}

      - name: Test
        run: |
          python --version

Outputs something like:

Run python --version
Python 3.6.9 (d38cd66c14b8, Sep 23 2020, 08:01:17)
[PyPy 7.3.2 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

or:

Run python --version
Python 2.7.13 (6abe2e00c51d, Sep 23 2020, 05:06:33)
[PyPy 7.3.2 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

Run/Repo Url
If applicable, and if your repo/run is public, please include a URL so it is easier for us to investigate.

https://github.com/hugovk/test/actions/runs/387431674
@hugovk hugovk added the bug Something isn't working label Nov 27, 2020
This was referenced Nov 27, 2020
Closed
Closed
< 8000 /div>
@konradpabjan konradpabjan added enhancement New feature or request and removed bug Something isn't working labels Dec 1, 2020
@hugovk hugovk mentioned this issue Dec 3, 2020
Merged
@webknjaz
Copy link
webknjaz commented Dec 4, 2020

@konradpabjan any timeline on this? It affects all the users of the most popular test automation tool — tox.

@altendky
Copy link
altendky commented Dec 4, 2020

I just so happened to add PyPy to a build tonight and it got 7.3.3.

https://github.com/twisted/towncrier/pull/289/checks?check_run_id=1495922903

pypy3-tests run-test: commands[0] | python -V
Python 3.6.12 (db1e853f94de, Nov 18 2020, 09:49:19)
[PyPy 7.3.3 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

@hugovk
Copy link
Contributor Author
hugovk commented Dec 4, 2020

Thanks for letting us know! I guess it's still being rolled out, I'm getting:

Python 3.6.9 (d38cd66c14b8, Sep 23 2020, 08:02:17)
[PyPy 7.3.2 with MSC v.1927 32 bit]

https://github.com/hugovk/pyflakes/runs/1497548176?check_suite_focus=true

@webknjaz
Copy link
webknjaz commented Dec 4, 2020

@hugovk you're pointing to a Windows build while @altendky points to Ubuntu. In your CI Ubuntu also gets 7.3.3.

But the tox problem is happening on Windows specifically. I haven't seen this problem in other envs.

@altendky
Copy link
altendky commented Dec 5, 2020

Sorry about that. :[ Here's a Windows build with 7.3.3 inside tox. (hopefully?)

https://github.com/pytest-dev/pytest-twisted/runs/1500183454

============================= test session starts =============================
platform win32 -- Python 3.6.12[pypy-7.3.3-final], pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- d:\a\pytest-twisted\pytest-twisted\.tox\pypy3-defaultreactor\scripts\python.exe

@konradpabjan
Copy link
Collaborator
konradpabjan commented Dec 5, 2020 •
edited
Loading

We've started working on this. Some discussion have come up here: #161 but internally we've been planning on getting this done for much longer but we just haven't had the bandwidth. (Keep your eyes out for Universe next week 😉 lots of exciting new things coming to Actions)

We'll be knocking out different versions of PyPy + Nightly PyPy in one go. Expect this to land very very soon

@maxim-lobanov
B075 Copy link
Contributor

All images were updated and currently contains PyPy 7.3.3 so I am going to close this issue.
The work that @konradpabjan mentioned will provide ability to install any version of PyPy on-flight to avoid delays with image updates in future.

@hugovk
Copy link
Contributor Author
hugovk commented Dec 7, 2020

Confirmed on a re-run:

Run python --version
Python 3.6.12 (db1e853f94de, Nov 18 2020, 09:49:19)
[PyPy 7.3.3 with GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

https://github.com/hugovk/pyflakes/runs/1510904237

Thanks everyone!

This was referenced Dec 7, 2020
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@altendky @webknjaz @hugovk @konradpabjan @maxim-lobanov
0