8000 Recommend ruby/setup-ruby's bundler-cache: true option by eregon · Pull Request #514 · actions/cache · GitHub
[go: up one dir, main page]
Skip to content

Recommend ruby/setup-ruby's bundler-cache: true option #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2021
Merged

Recommend ruby/setup-ruby's bundler-cache: true option #514

merged 1 commit into from
Feb 2, 2021

Conversation

eregon
Copy link
Contributor
@eregon eregon commented Jan 28, 2021

Manually caching gems has many issues:

  • Not working if there is no Gemfile.lock but only a Gemfile
  • Not having the OS version in the key, which might cause binary incompatibility with system libraries of different ABI version.
  • Not taking the Ruby version in account.
  • Not taking the Ruby ABI version of development builds into accounts, which cannot be done with a key, but needs the commit hash.
  • Using restore-keys would grow the cache over time and have extra gems in the cache.
  • Those reasons are summarized in https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby#caching-bundle-install-manually

@eregon
Recommend ruby/setup-ruby's bundler-cache: true option
1bfe3ac 
Manually caching gems has many issues:
* Not working if there is no Gemfile.lock but only a Gemfile
* Not having the OS version in the key, which might cause binary incompatibility with system libraries of different ABI version.
* Not taking the Ruby version in account.
* Not taking the Ruby ABI version of development builds into accounts, which cannot be done with a key, but needs the commit hash.
* Using restore-keys would grow the cache over time and have extra gems in the cache.
* Those reasons are summarized in https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby#caching-bundle-install-manually
@eregon eregon requested a review from a team as a code owner January 28, 2021 11:59
konradpabjan
konradpabjan approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor
@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with dropping the example and recommending bundler-cache: true 👍

@konradpabjan konradpabjan merged commit 56a8a2f into actions:main Feb 2, 2021
@dhadka
Copy link
Contributor
dhadka commented Feb 2, 2021

👍 Awesome!

This was referenced Mar 6, 2021
Merged
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Merged
Closed
This was referenced Mar 16, 2021
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradpabjan konradpabjan konradpabjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eregon @dhadka @konradpabjan
0