Improved gradle cache key calculation example #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradpabjan
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
Thanks for this PR! @odin-delrio
We have a public repo for our docs where you can update the Gradle example as well. See this file: https://github.com/github/docs/blob/main/content/actions/guides/building-and-testing-java-with-gradle.md
3 tasks
This was referenced Mar 6, 2021
This was referenced Mar 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Without taking into account the
gradle-wrapper.propertiesfor the cache key, whenever the gradle version gets updated in that file, GH cache will still use the cache generated for the previous version.That will make subsequent builds to regenerate the
gradle-api-XX.jarartifact every single time, and that operation is very expensive, 25 seconds in the build I detected this on a GH Actions runner.Example log indicating that expensive operation being executed:
Proposed change
Provide an example that actually takes the
gradle-wrapper.propertiesinto account for the cache key generation, so if the gradle version gets updated the cache will be regenerated, making subsequent builds much faster.Also, it would be nice that the example provided in the webiste docs is aligned with these ones, currently the one in the web doesn't match with the one here for gradle.