no-unreachable-loop

abrahamguo · abrahamguo · commit 0d0e9075cd70 · 2024-07-10T23:57:42.000-05:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -206,6 +206,7 @@ export default tseslint.config(
         'error',
         { commentPattern: '.*intentional fallthrough.*' },
       ],
+      'no-unreachable-loop': 'error',
       'one-var': ['error', 'never'],
 
       //
diff --git a/packages/eslint-plugin/src/rules/no-mixed-enums.ts b/packages/eslint-plugin/src/rules/no-mixed-enums.ts
@@ -170,18 +170,15 @@ export default createRule({
           .getSymbolAtLocation(tsNode)!
           .getDeclarations()!;
 
-        for (const declaration of declarations) {
-          for (const member of (declaration as ts.EnumDeclaration).members) {
-            return member.initializer
-              ? tsutils.isTypeFlagSet(
-                  typeChecker.getTypeAtLocation(member.initializer),
-                  ts.TypeFlags.StringLike,
-                )
-                ? AllowedType.String
-                : AllowedType.Number
-              : AllowedType.Number;
-          }
-        }
+        const [{ initializer }] = (declarations[0] as ts.EnumDeclaration)
+          .members;
+        return initializer &&
+          tsutils.isTypeFlagSet(
+            typeChecker.getTypeAtLocation(initializer),
+            ts.TypeFlags.StringLike,
+          )
+          ? AllowedType.String
+          : AllowedType.Number;
       }
 
       // Finally, we default to the type of the first enum member
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-return.ts b/packages/eslint-plugin/src/rules/no-unsafe-return.ts
@@ -166,7 +166,8 @@ export default createRule({
         });
       }
 
-      for (const signature of functionType.getCallSignatures()) {
+      const signature = functionType.getCallSignatures().at(0);
+      if (signature) {
         const functionReturnType = signature.getReturnType();
         const result = isUnsafeAssignment(
           returnNodeType,

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,8 @@ export default createRule({`
`166`	`166`	`});`
`167`	`167`	`}`
`168`	`168`
`169`		`- for (const signature of functionType.getCallSignatures()) {`
	`169`	`+ const signature = functionType.getCallSignatures().at(0);`
	`170`	`+ if (signature) {`
`170`	`171`	`const functionReturnType = signature.getReturnType();`
`171`	`172`	`const result = isUnsafeAssignment(`
`172`	`173`	`returnNodeType,`