minor symfony#52796 [DependencyInjection] remove useless setAccessible() calls (xabbuh)

nicolas-grekas · nicolas-grekas · commit 62835974fdfd · 2023-11-29T16:26:53.000+01:00
This PR was merged into the 7.1 branch. Discussion ---------- [DependencyInjection] remove useless setAccessible() calls | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- d8e48ac remove useless setAccessible() calls
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -420,7 +420,6 @@ public function testGetEnvDoesNotAutoCastNullWithDefaultEnvVarProcessor()
         $container->compile();
 
         $r = new \ReflectionMethod($container, 'getEnv');
-        $r->setAccessible(true);
         $this->assertNull($r->invoke($container, 'FOO'));
     }
 
@@ -436,7 +435,6 @@ public function testGetEnvDoesNotAutoCastNullWithEnvVarProcessorsLocatorReturnin
         $container->compile();
 
         $r = new \ReflectionMethod($container, 'getEnv');
-        $r->setAccessible(true);
         $this->assertNull($r->invoke($container, 'FOO'));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,6 @@ public function testGetEnvDoesNotAutoCastNullWithDefaultEnvVarProcessor()`
`420`	`420`	`$container->compile();`
`421`	`421`
`422`	`422`	`$r = new \ReflectionMethod($container, 'getEnv');`
`423`		`- $r->setAccessible(true);`
`424`	`423`	`$this->assertNull($r->invoke($container, 'FOO'));`
`425`	`424`	`}`
`426`	`425`
`@@ -436,7 +435,6 @@ public function testGetEnvDoesNotAutoCastNullWithEnvVarProcessorsLocatorReturnin`
`436`	`435`	`$container->compile();`
`437`	`436`
`438`	`437`	`$r = new \ReflectionMethod($container, 'getEnv');`
`439`		`- $r->setAccessible(true);`
`440`	`438`	`$this->assertNull($r->invoke($container, 'FOO'));`
`441`	`439`	`}`
`442`	`440`	`}`