8000 `--use_mlock` arg is confusing · Issue #719 · abetlen/llama-cpp-python · GitHub
[go: up one dir, main page]

Skip to content
--use_mlock arg is confusing #719
Closed
Closed
@jamesbraza

Description

@jamesbraza

With llama-cpp-python==0.2.5's server help:

python -m llama_cpp.server --help
  ...
  --use_mmap USE_MMAP   Disable Use mmap. (default: True)
  --use_mlock USE_MLOCK
                        Disable Use mlock. (default: True)

The arg name is "use mlock", and the description is "disable use mlock".

These are opposite meanings, it's unclear what will actually take place without reading the implementation. Can we update the docstrings? Thanks in advance, sorry for a nit

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0