Merge pull request #4 from abelsensors/feature/VV-3453_FixWatchdogTimeouts

ElmerAbel · web-flow · commit 3181cb3831ef · 2025-03-17T16:55:51.000+01:00
VV-3453 Add timeout check to HTTPConnection::updateBuffer
diff --git a/src/HTTPConnection.cpp b/src/HTTPConnection.cpp
@@ -211,8 +211,14 @@ int HTTPConnection::updateBuffer() {
           closeConnection();
           return -1;
         }
-
-      } // data pending
+      // This function can be called in a loop when discarding the request body in HTTPRequest::discardRequestBody. 
+      // When the connection for whatever reason is unable to receive more data, the application essentially gets  
+      // stuck in an infinite while loop. This extra timeout check prevents this from occurring.
+      } else if (isTimeoutExceeded()) {
+        HTTPS_LOGI("Connection timeout. FID=%d", _socket);
+        closeConnection();
+        return -1;
+      }
 
     } // buffer can read more
   }
