Allow Ethernet devices on SPI1 (earlephilhower#1725)

Ing-Dom · web-flow · commit 7e8fcc5afa06 · 2023-09-22T11:54:53.000-07:00
_spiUnit is a reference, and when initialized with SPI, it cannot be changed in the constructor afterwards.
So initialize it in the constructor's declaration.
diff --git a/libraries/lwIP_Ethernet/src/LwipIntfDev.h b/libraries/lwIP_Ethernet/src/LwipIntfDev.h
@@ -57,8 +57,7 @@ template<class RawDev>
 class LwipIntfDev: public LwipIntf, public RawDev {
 public:
     LwipIntfDev(int8_t cs = SS, SPIClass& spi = SPI, int8_t intr = -1) :
-        RawDev(cs, spi, intr), _mtu(DEFAULT_MTU), _intrPin(intr), _started(false), _default(false) {
-        _spiUnit = spi;
+        RawDev(cs, spi, intr), _spiUnit(spi), _mtu(DEFAULT_MTU), _intrPin(intr), _started(false), _default(false) {
         memset(&_netif, 0, sizeof(_netif));
     }
 
@@ -135,7 +134,7 @@ class LwipIntfDev: public LwipIntf, public RawDev {
     err_t handlePackets();
 protected:
     // members
-    SPIClass &_spiUnit = SPI;
+    SPIClass& _spiUnit;
     SPISettings _spiSettings = SPISettings(4000000, MSBFIRST, SPI_MODE0);
     netif _netif;
 
