8000 Template params can only have one argument · WyriHaximus-labs/dns@07653f3 · GitHub
[go: up one dir, main page]

Skip to content

Commit 07653f3

Browse files
committed
Template params can only have one argument
The fact that a promise can also be rejected with a Throwable and/or Exception is implied and there is no need to also define that here. Refs: reactphp/promise#223
1 parent 2de95d5 commit 07653f3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ See also the wiki for possible [cache implementations](https://github.com/reactp
115115

116116
### resolve()
117117

118-
The `resolve(string $domain): PromiseInterface<string,Exception>` method can be used to
118+
The `resolve(string $domain): PromiseInterface<string>` method can be used to
119119
resolve the given $domain name to a single IPv4 address (type `A` query).
120120

121121
```php
@@ -151,7 +151,7 @@ $promise->cancel();
151151

152152
### resolveAll()
153153

154-
The `resolveAll(string $host, int $type): PromiseInterface<array,Exception>` method can be used to
154+
The `resolveAll(string $host, int $type): PromiseInterface<array>` method can be used to
155155
resolve all record values for the given $domain name and query $type.
156156

157157
```php

src/Query/ExecutorInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ interface ExecutorInterface
3636
* ```
3737
*
3838
* @param Query $query
39-
* @return \React\Promise\PromiseInterface<\React\Dns\Model\Message,\Exception>
39+
* @return \React\Promise\PromiseInterface<\React\Dns\Model\Message>
4040
* resolves with response message on success or rejects with an Exception on error
4141
*/
4242
public function query(Query $query);

src/Resolver/ResolverInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ interface ResolverInterface
3939
* ```
4040
*
4141
* @param string $domain
42-
* @return \React\Promise\PromiseInterface<string,\Exception>
42+
* @return \React\Promise\PromiseInterface<string>
4343
* resolves with a single IP address on success or rejects with an Exception on error.
4444
*/
4545
public function resolve($domain);
@@ -87,7 +87,7 @@ public function resolve($domain);
8787
* ```
8888
*
8989
* @param string $domain
90-
* @return \React\Promise\PromiseInterface<array,\Exception>
90+
* @return \React\Promise\PromiseInterface<array>
9191
* Resolves with all record values on success or rejects with an Exception on error.
9292
*/
9393
public function resolveAll($domain, $type);

0 commit comments

Comments
 (0)
0