bug symfony#52963 [FrameworkBundle] Fix profiling commands without router (HeahDude)

fabpot · fabpot · commit fec89090f178 · 2023-12-09T13:09:50.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix profiling commands without router | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | symfony#52943 | License | MIT Commits ------- 7fba074 [FrameworkBundle] Fix profiling commands without router
diff --git a/src/Symfony/Bundle/FrameworkBundle/EventListener/ConsoleProfilerListener.php b/src/Symfony/Bundle/FrameworkBundle/EventListener/ConsoleProfilerListener.php
@@ -43,7 +43,7 @@ public function __construct(
         private readonly RequestStack $requestStack,
         private readonly Stopwatch $stopwatch,
         private readonly bool $cliMode,
-        private readonly UrlGeneratorInterface $urlGenerator,
+        private readonly ?UrlGeneratorInterface $urlGenerator = null,
     ) {
         $this->profiles = new \SplObjectStorage();
         $this->parents = new \SplObjectStorage();
@@ -140,12 +140,14 @@ public function profile(ConsoleTerminateEvent $event): void
             $p = $this->profiles[$r];
             $this->profiler->saveProfile($p);
 
-            $token = $p->getToken();
-            $output?->writeln(sprintf(
-                'See profile <href=%s>%s</>',
-                $this->urlGenerator->generate('_profiler', ['token' => $token], UrlGeneratorInterface::ABSOLUTE_URL),
-                $token
-            ));
+            if ($this->urlGenerator && $output) {
+                $token = $p->getToken();
+                $output->writeln(sprintf(
+                    'See profile <href=%s>%s</>',
+                    $this->urlGenerator->generate('_profiler', ['token' => $token], UrlGeneratorInterface::ABSOLUTE_URL),
+                    $token
+                ));
+            }
         }
 
         $this->profiles = new \SplObjectStorage();
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.php
@@ -44,7 +44,7 @@
                 service('.virtual_request_stack'),
                 service('debug.stopwatch'),
                 param('kernel.runtime_mode.cli'),
-                service('router'),
+                service('router')->nullOnInvalid(),
             ])
             ->tag('kernel.event_subscriber')
 
