minor symfony#51168 [Messenger] Add forward compatibily with php-amqp v2 (lyrixx)

fabpot · fabpot · commit 2f1ba4cb3fb4 · 2023-08-01T17:38:48.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Add forward compatibily with php-amqp v2 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | see php-amqp/php-amqp#424 (comment) Commits ------- 9593910 [Messenger] Add forward compatibily with php-amqp v2
diff --git a/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
@@ -456,7 +456,7 @@ public function get(string $queueName): ?\AMQPEnvelope
 
     public function ack(\AMQPEnvelope $message, string $queueName): bool
     {
-        return $this->queue($queueName)->ack($message->getDeliveryTag());
+        return $this->queue($queueName)->ack($message->getDeliveryTag()) ?? true;
     }
 
     public function nack(\AMQPEnvelope $message, string $queueName, int $flags = \AMQP_NOPARAM): bool

Original file line number	Diff line number	Diff line change
`@@ -456,7 +456,7 @@ public function get(string $queueName): ?\AMQPEnvelope`
`456`	`456`
`457`	`457`	`public function ack(\AMQPEnvelope $message, string $queueName): bool`
`458`	`458`	`{`
`459`		`- return $this->queue($queueName)->ack($message->getDeliveryTag());`
	`459`	`+ return $this->queue($queueName)->ack($message->getDeliveryTag()) ?? true;`
`460`	`460`	`}`
`461`	`461`
`462`	`462`	`public function nack(\AMQPEnvelope $message, string $queueName, int $flags = \AMQP_NOPARAM): bool`