E591 [WebGPU] hello-cube.html asserts in debug · WebKit/WebKit@a11c15f · GitHub
[go: up one dir, main page]
Skip to content

Commit a11c15f

Browse files
mwyrzykowskimwyrzykowski
committed
[WebGPU] hello-cube.html asserts in debug
https://bugs.webkit.org/show_bug.cgi?id=251184 <rdar://problem/104673910> Reviewed by Myles C. Maxfield. This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=250956 which applies the same patch but for the alternate constructor. * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::RenderPipeline): Don't attempt to create the depth stencil state if the passed in descriptor is nil. Canonical link: https://commits.webkit.org/259403@main
1 parent 12370c7 commit a11c15f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎Source/WebGPU/WebGPU/RenderPipeline.mm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,7 +509,7 @@ static void populateStencilOperation(MTLStencilDescriptor *mtlStencil, const WGP
509509
, m_frontFace(frontFace)
510510
, m_cullMode(cullMode)
511511
, m_depthStencilDescriptor(depthStencilDescriptor)
512-
, m_depthStencilState([device.device() newDepthStencilStateWithDescriptor:depthStencilDescriptor])
512+
, m_depthStencilState(depthStencilDescriptor ? [device.device() newDepthStencilStateWithDescriptor:depthStencilDescriptor] : nil)
513513
, m_pipelineLayout(&pipelineLayout)
514514
, m_vertexShaderInputBufferCount(vertexShaderInputBufferCount)
515515
{

0 commit comments

Comments
 (0)
0