10BC0 Remove ITPDebugModeEnabled & PrivateClickMeasurementDebugModeEnabled … · WebKit/WebKit@5192e92 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5192e92

Browse files
nt1machristensen07
nt1m
authored and
achristensen07
committed
Remove ITPDebugModeEnabled & PrivateClickMeasurementDebugModeEnabled from DeprecatedGlobalSettings
https://bugs.webkit.org/show_bug.cgi?id=250292 rdar://103998304 Reviewed by Alex Christensen. The methods on DeprecatedGlobalSettings don't seem used. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/page/DeprecatedGlobalSettings.h: (WebCore::DeprecatedGlobalSettings::setItpDebugModeEnabled): Deleted. (WebCore::DeprecatedGlobalSettings::itpDebugModeEnabled): Deleted. (WebCore::DeprecatedGlobalSettings::privateClickMeasurementDebugModeEnabled): Deleted. (WebCore::DeprecatedGlobalSettings::setPrivateClickMeasurementDebugModeEnabled): Deleted. Canonical link: https://commits.webkit.org/258679@main
1 parent 70ccbd9 commit 5192e92

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

‎Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3037,12 +3037,13 @@ ItpDebugModeEnabled:
30373037
status: developer
30383038
humanReadableName: "ITP Debug Mode"
30393039
humanReadableDescription: "Intelligent Tracking Prevention Debug Mode"
3040-
webcoreBinding: DeprecatedGlobalSettings
30413040
defaultValue:
30423041
WebKitLegacy:
30433042
default: false
30443043
WebKit:
30453044
default: false
3045+
WebCore:
3046+
default: false
30463047

30473048
JavaScriptCanAccessClipboard:
30483049
type: bool
@@ -4486,12 +4487,13 @@ PrivateClickMeasurementDebugModeEnabled:
44864487
status: developer
44874488
humanReadableName: "Private Click Measurement Debug Mode"
44884489
humanReadableDescription: "Enable Private Click Measurement Debug Mode"
4489-
webcoreBinding: DeprecatedGlobalSettings
44904490
defaultValue:
44914491
WebKitLegacy:
44924492
default: false
44934493
WebKit:
44944494
default: false
4495+
WebCore:
4496+
default: false
44954497

44964498
PrivateClickMeasurementEnabled:
44974499
type: bool

‎Source/WebCore/page/DeprecatedGlobalSettings.h‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,6 @@ class DeprecatedGlobalSettings {
9494
static bool fetchAPIKeepAliveEnabled() { return shared().m_fetchAPIKeepAliveEnabled; }
9595
static void setFetchAPIKeepAliveEnabled(bool isEnabled) { shared().m_fetchAPIKeepAliveEnabled = isEnabled; }
9696

97-
static void setItpDebugModeEnabled(bool isEnabled) { shared().m_itpDebugMode = isEnabled; }
98-
static bool itpDebugModeEnabled() { return shared().m_itpDebugMode; }
99-
10097
static void setRestrictedHTTPResponseAccess(bool isEnabled) { shared().m_isRestrictedHTTPResponseAccess = isEnabled; }
10198
static bool restrictedHTTPResponseAccess() { return shared().m_isRestrictedHTTPResponseAccess; }
10299

@@ -139,9 +136,6 @@ class DeprecatedGlobalSettings {
139136
static void setLineHeightUnitsEnabled(bool isEnabled) { shared().m_lineHeightUnitsEnabled = isEnabled; }
140137
static bool lineHeightUnitsEnabled() { return shared().m_lineHeightUnitsEnabled; }
141138

142-
static bool privateClickMeasurementDebugModeEnabled() { return shared().m_privateClickMeasurementDebugModeEnabled; }
143-
static void setPrivateClickMeasurementDebugModeEnabled(bool isEnabled) { shared().m_privateClickMeasurementDebugModeEnabled = isEnabled; }
144-
145139
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
146140
static void setIsAccessibilityIsolatedTreeEnabled(bool isEnabled) { shared().m_accessibilityIsolatedTree = isEnabled; }
147141
static bool isAccessibilityIsolatedTreeEnabled() { return shared().m_accessibilityIsolatedTree; }
@@ -225,7 +219,6 @@ class DeprecatedGlobalSettings {
225219

226220
bool m_isCustomPasteboardDataEnabled { false };
227221
bool m_fetchAPIKeepAliveEnabled { false };
228-
bool m_itpDebugMode { false };
229222
bool m_isRestrictedHTTPResponseAccess { true };
230223
bool m_isServerTimingEnabled { false };
231224
bool m_attrStyleEnabled { false };
@@ -250,8 +243,6 @@ class DeprecatedGlobalSettings {
250243

251244
bool m_lineHeightUnitsEnabled { true };
252245

253-
bool m_privateClickMeasurementDebugModeEnabled { false };
254-
255246
#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
256247
bool m_accessibilityIsolatedTree { false };
257248
#endif

0 commit comments

Comments
 (0)
0