8000 Shorthands are still using "initial" for longhands that are set impli… · WebKit/WebKit@03224cf · GitHub
[go: up one dir, main page]
Skip to content

Commit 03224cf

Browse files
darinadlerdarinadler
committed
Shorthands are still using "initial" for longhands that are set implicitly
https://bugs.webkit.org/show_bug.cgi?id=248913 rdar://problem/103092939 Reviewed by Sam Weinig and Oriol Brufau. This removes all the remaining cases that use "initial" for longhands, moving to initial values instead, but keeping the initial value placeholder for performance reasons. We now serialize properties based on checking if longhands have their initial values, and are not relying on the implicit flag. That's because in the case of layered shorthands, we can no longer use the implicit flag; there is nothing that stores those in the layers. We plan to rely on values and not the implicit flag universally; in another change soon we will finish the job. I have additional removal and tidying, including renaming createImplicitInitialValue since it is now a placeholder that represents initial values without having to allocate the memory for them, rather than a special "implicit" value. But since this is already a large change, holding those changes for followup. * LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt: * LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt: Updated for change where we end up putting in a "background-image: none". This is a regression, but not an important one, and improving this to instead emit "background: transparent" or "background: none" will probably involve improving the editing code rather than the CSS code. * LayoutTests/editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt: Updated for progression where we use the background shorthand, not background-color. * LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: * LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt: * LayoutTests/fast/css/background-clip-text-expected.txt: Expect more tests to pass. * LayoutTests/fast/css/background-position-serialize-expected.txt: Progression where we serialize background shorthand instead of background-image and background-position longhands. * LayoutTests/fast/css/border-shorthand-initialize-longhands-expected.txt: * LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt: * LayoutTests/fast/css/parsing-text-emphasis-expected.txt: Expect more tests to pass. * LayoutTests/fast/css/remove-shorthand-expected.txt: Expect various shorthands to be handled correctly, such as adding border-image, handling the background shorthand, and others. * LayoutTests/fast/css/shorthand-mismatched-list-crash-expected.txt: Expect test to pass. * LayoutTests/fast/css/transform-inline-style-expected.txt: Don't expect initial values "ease" and "0s" to be serialized. * LayoutTests/fast/css/transform-inline-style-remove-expected.txt: Ditto, also initial values "none" and "running". * LayoutTests/fast/dom/background-shorthand-csstext-expected.txt: * LayoutTests/fast/masking/parsing-mask-expected.txt: * LayoutTests/fast/masking/parsing-webkit-mask-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/style-src/inline-style-allowed-while-cloning-objects.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/border-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-position-valid-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-multicol/parsing/column-rule-shorthand-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-cssText-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/border-shorthand-serialization-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/serialize-values-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/shorthand-values-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/css/css-masking/parsing/mask-valid.sub-expected.txt: Expect more tests to pass. * Source/WebCore/css/CSSProperties.json: Added the border-image longhands to the border shorthand, because the border shorthand sets all these properties to initial values. Also sort the offset shorthand longhands in the order from the specification. * Source/WebCore/css/StyleProperties.cpp: (WebCore::textExpandingInitialValuePlaceholder): Added. (WebCore::valueIDExpandingInitialValuePlaceholder): Added. (WebCore::StyleProperties::getPropertyValue const): Added a call to textExpandingInitialValuePlaceholder so we expand the shorthand rather than serializing "initial". Removed the borderSpacingValue function and use the get2Values function instead for border-spacing. If border-image shorthand values don't all have their initial values, then do not serialize the border shorthand. Use getPropertyValue instead of getPropertyCSSValue and cssText so we get the additional initial value placeholder logic. (WebCore::StyleProperties::propertyAsColor const): Use textExpandingInitialValuePlaceholder. (WebCore::StyleProperties::propertyAsValueID const): Use valueIDExpandingInitialValuePlaceholder. (WebCore::StyleProperties::borderSpacingValue const): Deleted. (WebCore::StyleProperties::fontValue const): Use textExpandingInitialValuePlaceholder. (WebCore::StyleProperties::fontVariantValue const): Check isImplicitInitialValue since that's a second way the value normal coul 8000 d be specified. (WebCore::StyleProperties::get2Values const): Rewrote more simply, removing the isInitialValue checks since commonShorthandChecks takes care of that now. Also use makeString instead of StringBuilder since we can and it's more efficient. (WebCore::StyleProperties::get4Values const): Rewrote more simply, removing the isInherited and isInitialValue checks since commonShorthandChecks takes care of that now. Also use makeString instead of StringBuilder since we can and it's more efficient. (WebCore::LayerValues::LayerValues): Added. (WebCore::LayerValues::set): Added. (WebCore::LayerValues::skip): Added. (WebCore::LayerValues::valueID const): Added. (WebCore::LayerValues::valueIDIncludingCustomIdent const): Added. (WebCore::LayerValues::equalValueIDs const): Added. (WebCore::LayerValues::isValueID const): Added. (WebCore::LayerValues::isPair const): Added. (WebCore::LayerValues::serialize const): Added. (WebCore::StyleProperties::getLayeredShorthandValue const): Rewrote this to use initial values instead of relying on implicit flags to know what to not serialize. Added various rules that were not present in the old version that are now needed for round tripping and omitting any value that can be without changing the meaning. The LayerValues class above is part of this rewrite. (WebCore::StyleProperties::getShorthandValue const): Use getPropertyValue instead of getPropertyCSSValue and cssText so we get the additional initial value placeholder logic. (WebCore::StyleProperties::getCommonValue const): Ditto. (WebCore::StyleProperties::borderImagePropertyValue const): Serialize as "none" when everything has the implicit flag set. (WebCore::StyleProperties::borderPropertyValue const): Rewrote for simplicitly. Now checks for initial values instead of depending on the implicit flag, using string comparisons since that's the easiest way to build on getCommonValue. Also use makeString instead of StringBuilder. (WebCore::StyleProperties::pageBreakValue const): Use nameString for slightly better efficiency. (WebCore::StyleProperties::webkitColumnBreakValue const): Ditto. (WebCore::StyleProperties::hasAllInitialValues const): Added. (WebCore::canUseShorthandForLonghand): Allow use of the CSSPropertyBackground shorthand, which did not work well before getLayeredShorthandValue omitted initial values. (WebCore::StyleProperties::asTextInternal const): Removed now-incorrect handling of isImplicitInitialValue and use textExpandingInitialValuePlaceholder. * Source/WebCore/css/StyleProperties.h: Added hasAllInitialValues. Removed borderSpacingValue. * Source/WebCore/css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::addProperty): Merged addProperty and addPropertyWithImplicitDefault into a single function, which can take nullptr and replace it with the initial value placeholder. (WebCore::CSSPropertyParser::addExpandedProperty): Renamed from addExpandedPropertyForValue, changed to take nullptr like addProperty now does, and added an implicit flag. (WebCore::CSSPropertyParser::parseValueStart): Updated for addProperty and addExpandedProperty changes. (WebCore::CSSPropertyParser::consumeCSSWideKeyword): Ditto. (WebCore::CSSPropertyParser::parseCounterStyleDescriptor): Ditto. (WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto. (WebCore::CSSPropertyParser::parsePropertyDescriptor): Ditto. (WebCore::CSSPropertyParser::parseFontPaletteValuesDescriptor): Ditto. (WebCore::CSSPropertyParser::consumeFontVariantShorthand): Ditto. (WebCore::CSSPropertyParser::consumeColumns): Ditto. (WebCore::initialValueForLonghand): Added. (WebCore::initialCSSValueForAnimationLonghand): Added. (WebCore::isNumber): Added. (WebCore::pairValue): Added. (WebCore::quadValue): Added. (WebCore::isValueIDPair): Added. (WebCore::isNumericQuad): Added. (WebCore::isInitialValueForLonghand): Added. (WebCore::initialValueTextForLonghand): Added. (WebCore::initialValueIDForLonghand): Added. (WebCore::CSSPropertyParser::consumeShorthandGreedily): Updated for addProperty changes. (WebCore::CSSPropertyParser::consumeBorderShorthand): Renamed from consumeBorder. Do the calls to addExpandedProperty here instead of in the caller. Updated for addProperty changes. (WebCore::CSSPropertyParser::consumeBorderImage): Udpated for addProperty changes. This removed the need to create value objects since we now use the initial value placeholder. (WebCore::CSSPropertyParser::consumeAnimationShorthand): Use initialCSSValueForAnimationLonghand instead of ComputedStyleExtractor::addValueForAnimationPropertyToList. Updated for addProperty changes. (WebCore::CSSPropertyParser::consumeBackgroundShorthand): Removed local variable "implicit" that was always false. Updated for addProperty changes. (WebCore::CSSPropertyParser::consumeOverscrollBehaviorShorthand): Updated for addProperty changes. (WebCore::CSSPropertyParser::consumeContainerShorthand): Ditto. (WebCore::CSSPropertyParser::consumeContainIntrinsicSizeShorthand): Ditto. (WebCore::CSSPropertyParser::consumeTransformOrigin): Ditto. (WebCore::CSSPropertyParser::consumeOffset): Ditto. (WebCore::CSSPropertyParser::consumeListStyleShorthand): Ditto. (WebCore::CSSPropertyParser::parseShorthand): Use consumeBorderShorthand. For CSSPropertyBorder itself, also set all the border-image longhands to their initial values. * Source/WebCore/css/parser/CSSPropertyParser.h: Updated the addProperty and addExpandedProperty functions. Replaced consumeBorder with consumeBorderShorthand. Added isInitialValueForLonghand, initialValueTextForLonghand, and intialValueIDForLonghand, exported by the parser but used by the serialization code. Canonical link: https://commits.webkit.org/258767@main
1 parent 322e588 commit 03224cf
  • css-variables
  • cssom
  • platform/glib/imported/w3c/web-platform-tests/css/css-masking/parsing
  • Source/WebCore/css

    • 32 files changed

    +886
    -548
    lines changed

    ‎LayoutTests/editing/deleting/paste-with-transparent-background-color-expected.txt‎

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -13,7 +13,7 @@ After cut and paste:
    1313
    | "hello "
    1414
    | <span>
    1515
    | class="test"
    16-
    | style="background-color: transparent;"
    16+
    | style="background-image: none; background-color: transparent;"
    1717
    | "world"
    1818
    | " WebKit<#selection-caret>"
    1919
    | <br>

    ‎LayoutTests/editing/deleting/paste-with-transparent-background-color-live-range-expected.txt‎

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -13,7 +13,7 @@ After cut and paste:
    1313
    | "hello "
    1414
    | <span>
    1515
    | class="test"
    16-
    | style="background-color: transparent;"
    16+
    | style="background-image: none; background-color: transparent;"
    1717
    | "world"
    1818
    | " WebKit<#selection-caret>"
    1919
    | <br>

    ‎LayoutTests/editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt‎

    Lines changed: 2 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -42,9 +42,9 @@ first test - after:
    4242
    | style="position: relative;"
    4343
    | "Before "
    4444
    | <div>
    45-
    | style="position: absolute; top: 0px; right: 0px; width: 100px; height: 100px; background-color: yellow;"
    45+
    | style="position: absolute; top: 0px; right: 0px; width: 100px; height: 100px; background: yellow;"
    4646
    | <div>
    47-
    | style="float: right; width: 200px; height: 200px; background-color: blue;"
    47+
    | style="float: right; width: 200px; height: 200px; background: blue;"
    4848
    | "After<#selection-caret>"
    4949
    | <div>
    5050
    | style="clear: both;"

    ‎LayoutTests/fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt‎

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -3,7 +3,7 @@ Tests a flag to make background shorthand property not override background-size
    33
    On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44

    55

    6-
    FAIL e.style.background should be url("dummy://test.png") center center / cover no-repeat border-box red. Was url("dummy://test.png") center center / cover no-repeat border-box border-box red.
    6+
    PASS e.style.background is 'url("dummy://test.png") center center / cover no-repeat border-box red'
    77
    PASS e.style.backgroundSize is 'cover'
    88

    99
    PASS successfullyParsed is true

    ‎LayoutTests/fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt‎

    Lines changed: 6 additions & 6 deletions
    Original file line numberDiff line numberDiff line change
    @@ -3,14 +3,14 @@ Tests background shortand property with background-size
    33
    On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44

    55

    6-
    FAIL e.style.background should be url("dummy://test.png") center center / cover no-repeat border-box red. Was url("dummy://test.png") center center / cover no-repeat border-box border-box red.
    6+
    PASS e.style.background is 'url("dummy://test.png") center center / cover no-repeat border-box red'
    77
    PASS e.style.backgroundSize is 'cover'
    88
    PASS checkStyle() is true
    99
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy://test.png") no-repeat scroll 50% 50% / cover border-box border-box'
    1010
    PASS computedStyle.getPropertyValue("background-size") is 'cover'
    1111
    PASS checkComputedStyleValue() is true
    1212

    13-
    FAIL e.style.background should be url("dummy://test.png") 20px center / contain no-repeat padding-box red. Was url("dummy://test.png") 20px center / contain no-repeat padding-box padding-box red.
    13+
    PASS e.style.background is 'url("dummy://test.png") 20px center / contain no-repeat padding-box red'
    1414
    PASS e.style.backgroundSize is 'contain'
    1515
    PASS checkStyle() is true
    1616
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy://test.png") no-repeat scroll 20px 50% / contain padding-box padding-box'
    @@ -31,7 +31,7 @@ PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy:
    3131
    PASS computedStyle.getPropertyValue("background-size") is '100px 200px'
    3232
    PASS checkComputedStyleValue() is true
    3333

    34-
    FAIL e.style.background should be url("dummy://test.png") 50% repeat content-box padding-box red. Was url("dummy://test.png") 50% center / auto repeat content-box padding-box red.
    34+
    PASS e.style.background is 'url("dummy://test.png") 50% repeat content-box padding-box red'
    3535
    PASS e.style.backgroundSize is 'auto'
    3636
    PASS checkStyle() is true
    3737
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy://test.png") repeat scroll 50% 50% / auto content-box padding-box'
    @@ -45,14 +45,14 @@ PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy:
    4545
    PASS computedStyle.getPropertyValue("background-size") is '50% auto'
    4646
    PASS checkComputedStyleValue() is true
    4747

    48-
    FAIL e.style.background should be url("dummy://test.png") left top / 100px auto repeat red. Was url("dummy://test.png") left top / 100px auto repeat scroll padding-box border-box red.
    48+
    PASS e.style.background is 'url("dummy://test.png") left top / 100px auto repeat red'
    4949
    PASS e.style.backgroundSize is '100px auto'
    5050
    PASS checkStyle() is true
    5151
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy://test.png") repeat scroll 0% 0% / 100px auto padding-box border-box'
    5252
    PASS computedStyle.getPropertyValue("background-size") is '100px auto'
    5353
    PASS checkComputedStyleValue() is true
    5454

    55-
    FAIL e.style.background should be url("dummy://test.png") 50% repeat fixed content-box red. Was url("dummy://test.png") 50% center / auto repeat fixed content-box content-box red.
    55+
    PASS e.style.background is 'url("dummy://test.png") 50% repeat fixed content-box red'
    5656
    PASS e.style.backgroundSize is 'auto'
    5757
    PASS checkStyle() is true
    5858
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) url("dummy://test.png") repeat fixed 50% 50% / auto content-box content-box'
    @@ -67,7 +67,7 @@ PASS computedStyle.getPropertyValue("background-size") is '50% auto'
    6767
    PASS checkComputedStyleValue() is true
    6868

    6969
    PASS e.style.background is 'fixed red'
    70-
    FAIL e.style.backgroundSize should be auto. Was initial.
    70+
    PASS e.style.backgroundSize is 'auto'
    7171
    PASS checkStyle() is true
    7272
    PASS computedStyle.getPropertyValue("background") is 'rgb(255, 0, 0) none repeat fixed 0% 0% / auto padding-box border-box'
    7373
    PASS computedStyle.getPropertyValue("background-size") is 'auto'

    ‎LayoutTests/fast/css/background-clip-text-expected.txt‎

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -16,7 +16,7 @@ PASS test("-webkit-background-clip: text", "background-clip") is ""
    1616
    PASS test("-webkit-background-clip: text", "-webkit-background-clip") is "text"
    1717
    PASS test("background: url() padding-box", "-webkit-background-clip") is ""
    1818
    PASS test("-webkit-mask: url() ", "background-clip") is ""
    19-
    FAIL test("background: url() ", "background-clip") should be border-box. Was initial.
    19+
    PASS test("background: url() ", "background-clip") is "border-box"
    2020
    PASS test("background: url() padding-box", "background-clip") is "padding-box"
    2121
    PASS test("background: url() text", "background-clip") is "text"
    2222
    PASS test("background: url() padding-box border-box", "background-clip") is "border-box"

    ‎LayoutTests/fast/css/background-position-serialize-expected.txt‎

    Lines changed: 1 addition & 1 deletion
    Original file line numberDiff line numberDiff line change
    @@ -72,4 +72,4 @@ PASS: window.getComputedStyle(t).backgroundPositionX should be right 20px and is
    7272
    t.setAttribute('style', 'background: url(about:blank) 80% 80%;');
    7373
    t.style.backgroundPositionY = '50px'
    7474
    style.cssText =
    75-
    background-image: url("about:blank"); background-position: 80% 50px;
    75+
    background: url("about:blank") 80% 50px;

    ‎LayoutTests/fast/css/border-shorthand-initialize-longhands-expected.txt‎

    Lines changed: 12 additions & 13 deletions
    Original file line numberDiff line numberDiff line change
    @@ -3,20 +3,19 @@ This test ensures border shorthand property initializes longhand properties such
    33
    On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
    44

    55

    6-
    FAIL div.setAttribute('style', 'border: 1px');div.style.borderTopStyle should be none. Was initial.
    7-
    FAIL div.style.borderRightStyle should be none. Was initial.
    8-
    FAIL div.style.borderBottomStyle should be none. Was initial.
    9-
    FAIL div.style.borderLeftStyle should be none. Was initial.
    10-
    FAIL div.style.borderTopColor should be currentcolor. Was initial.
    11-
    FAIL div.style.borderRightColor should be currentcolor. Was initial.
    12-
    FAIL div.style.borderBottomColor should be currentcolor. Was initial.
    13-
    FAIL div.style.borderLeftColor should be currentcolor. Was initial.
    14-
    FAIL div.setAttribute('style', 'border: solid');div.style.borderTopWidth should be medium. Was initial.
    15-
    FAIL div.style.borderRightWidth should be medium. Was initial.
    16-
    FAIL div.style.borderBottomWidth should be medium. Was initial.
    17-
    FAIL div.style.borderLeftWidth should be medium. Was initial.
    6+
    PASS div.setAttribute('style', 'border: 1px');div.style.borderTopStyle is "none"
    7+
    PASS div.style.borderRightStyle is "none"
    8+
    PASS div.style.borderBottomStyle is "none"
    9+
    PASS div.style.borderLeftStyle is "none"
    10+
    PASS div.style.borderTopColor is "currentcolor"
    11+
    PASS div.style.borderRightColor is "currentcolor"
    12+
    PASS div.style.borderBottomColor is "currentcolor"
    13+
    PASS div.style.borderLeftColor is "currentcolor"
    14+
    PASS div.setAttribute('style', 'border: solid');div.style.borderTopWidth is "medium"
    15+
    PASS div.style.borderRightWidth is "medium"
    16+
    PASS div.style.borderBottomWidth is "medium"
    17+
    PASS div.style.borderLeftWidth is "medium"
    1818
    PASS successfullyParsed is true
    19-
    Some tests failed.
    2019

    2120
    TEST COMPLETE
    2221

    ‎LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt‎

    Lines changed: 16 additions & 17 deletions
    Original file line numberDiff line numberDiff line change
    @@ -4,39 +4,38 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
    44

    55

    66
    Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
    7-
    FAIL expected element.style.animation to be "10s move" but got "10s ease 0s 1 normal none running move"
    8-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    7+
    PASS element.style.animation
    8+
    PASS element.style.cssText
    99

    1010
    Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
    11-
    FAIL expected element.style.animation to be "10s move" but got "10s ease 0s 1 normal none running move"
    12-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    11+
    PASS element.style.animation
    12+
    PASS element.style.cssText
    1313

    1414
    Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
    15-
    FAIL expected element.style.webkitAnimation to be "10s move" but got "10s ease 0s 1 normal none running move"
    16-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    15+
    PASS element.style.webkitAnimation
    16+
    PASS element.style.cssText
    1717

    1818
    Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
    19-
    FAIL expected element.style.webkitAnimation to be "10s move" but got "10s ease 0s 1 normal none running move"
    20-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    19+
    PASS element.style.webkitAnimation
    20+
    PASS element.style.cssText
    2121

    2222
    Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
    23-
    FAIL expected element.style.animation to be "10s move" but got "10s ease 0s 1 normal none running move"
    24-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    23+
    PASS element.style.animation
    24+
    PASS element.style.cssText
    2525

    2626
    Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
    27-
    FAIL expected element.style.animation to be "10s move" but got "10s ease 0s 1 normal none running move"
    28-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    27+
    PASS element.style.animation
    28+
    PASS element.style.cssText
    2929

    3030
    Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
    31-
    FAIL expected element.style.webkitAnimation to be "10s move" but got "10s ease 0s 1 normal none running move"
    32-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    31+
    PASS element.style.webkitAnimation
    32+
    PASS element.style.cssText
    3333

    3434
    Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
    35-
    FAIL expected element.style.webkitAnimation to be "10s move" but got "10s ease 0s 1 normal none running move"
    36-
    FAIL expected element.style.cssText to be "animation: 10s move;" but got "animation: 10s ease 0s 1 normal none running move;"
    35+
    PASS element.style.webkitAnimation
    36+
    PASS element.style.cssText
    3737

    3838
    PASS successfullyParsed is true
    39-
    Some tests failed.
    4039

    4140
    TEST COMPLETE
    4241

    ‎LayoutTests/fast/css/parsing-text-emphasis-expected.txt‎

    Lines changed: 2 additions & 2 deletions
    Original file line numberDiff line numberDiff line change
    @@ -48,8 +48,8 @@ PASS: '-webkit-text-emphasis-style: open "cheese";' parsed as ['', '', '', '']
    4848

    4949
    PASS: '-webkit-text-emphasis: initial' parsed as ['initial', '', 'initial', 'initial']
    5050
    PASS: '-webkit-text-emphasis: inherit' parsed as ['inherit', '', 'inherit', 'inherit']
    51-
    FAIL: '-webkit-text-emphasis: red' parsed as ['red', '', 'initial', 'red'] rather than ['red', '', 'none', 'red']
    52-
    FAIL: '-webkit-text-emphasis: "cheese"' parsed as ['initial', '', '"cheese"', '"cheese"'] rather than ['currentcolor', '', '"cheese"', '"cheese"']
    51+
    PASS: '-webkit-text-emphasis: red' parsed as ['red', '', 'none', 'red']
    52+
    PASS: '-webkit-text-emphasis: "cheese"' parsed as ['currentcolor', '', '"cheese"', '"cheese"']
    5353
    PASS: '-webkit-text-emphasis: red "cheese"' parsed as ['red', '', '"cheese"', '"cheese" red']
    5454
    PASS: '-webkit-text-emphasis: "cheese" red' parsed as ['red', '', '"cheese"', '"cheese" red']
    5555
    PASS: '-webkit-text-emphasis: filled sesame red' parsed as ['red', '', 'filled sesame', 'filled sesame red']

    0 commit comments

    Comments
     (0)
    0