add test for IncomingPhoneNumbers number types

Doug Black · Doug Black · commit a803eb23b5aa · 2013-10-16T14:21:57.000-07:00
diff --git a/tests/test_phone_numbers.py b/tests/test_phone_numbers.py
@@ -87,3 +87,37 @@ def test_base_uri(self):
         self.assertEquals(resource.parent.base_uri,
             ("https://api.twilio.com/2010-04-01/Accounts/AC4bf2dafbed59a573"
              "3d2c1c1c69a83a28"))
+
+
+class IncomingPhoneNumbersTest(unittest.TestCase):
+
+    def setUp(self):
+        self.resource = PhoneNumbers("http://api.twilio.com",
+                                     ("user", "pass"))
+
+    def test_mobile(self):
+        request = Mock()
+        request.return_value = (Mock(), {"incoming_phone_numbers": []})
+        self.resource.request = request
+        self.resource.list(type='mobile')
+
+        uri = "http://api.twilio.com/IncomingPhoneNumbers/Mobile"
+        request.assert_called_with("GET", uri, params={})
+
+    def test_local(self):
+        request = Mock()
+        request.return_value = (Mock(), {"incoming_phone_numbers": []})
+        self.resource.request = request
+        self.resource.list(type='local')
+
+        uri = "http://api.twilio.com/IncomingPhoneNumbers/Local"
+        request.assert_called_with("GET", uri, params={})
+
+    def test_toll_free(self):
+        request = Mock()
+        request.return_value = (Mock(), {"incoming_phone_numbers": []})
+        self.resource.request = request
+        self.resource.list(type='tollfree')
+
+        uri = "http://api.twilio.com/IncomingPhoneNumbers/TollFree"
+        request.assert_called_with("GET", uri, params={})
diff --git a/twilio/rest/resources/phone_numbers.py b/twilio/rest/resources/phone_numbers.py
@@ -259,17 +259,16 @@ def delete(self, sid):
         """
         return self.delete_instance(sid)
 
-    def list(self, **kwargs):
+    def list(self, type=None, **kwargs):
         """
         :param phone_number: Show phone numbers that match this pattern.
         :param friendly_name: Show phone numbers with this friendly name
         :param type: Filter numbers by type. Available types are
-            'local', 'mobile', or 'toll_free'
+            'local', 'mobile', or 'tollfree'
 
         You can specify partial numbers and use '*' as a wildcard.
         """
 
-        type = kwargs.get("type", None)
         if type:
             uri = "%s/%s" % (self.uri, TYPES[type])
 
