bug symfony#54776 [Cache] fix: remove unwanted cast to int (Arend Hummeling)

nicolas-grekas · nicolas-grekas · commit ad0caee64387 · 2024-04-30T09:49:50.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] fix: remove unwanted cast to int | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? |no | Issues | Fix symfony#54773 | License | MIT As discussed in the related issue, this type cast is unnecessary and can lead to unexpected behavior due to integer overflow. I took a quick look if a testcase could be implemented, but this is not so trivial, as we'd either have to somehow configure a redis server to end up with a state that results in very high scan cursor values, or we'd have to implement a mock for the redis implementation, so we can provide all the edge case values for our tests. Commits ------- 3d174a9 fix: remove unwanted type cast
diff --git a/src/Symfony/Component/Cache/Traits/RedisTrait.php b/src/Symfony/Component/Cache/Traits/RedisTrait.php
@@ -499,7 +499,7 @@ protected function doClear(string $namespace)
                     }
                     $this->doDelete($keys);
                 }
-            } while ($cursor = (int) $cursor);
+            } while ($cursor);
         }
 
         return $cleared;

Original file line number	Diff line number	Diff line change
`@@ -499,7 +499,7 @@ protected function doClear(string $namespace)`
`499`	`499`	`}`
`500`	`500`	`$this->doDelete($keys);`
`501`	`501`	`}`
`502`		`- } while ($cursor = (int) $cursor);`
	`502`	`+ } while ($cursor);`
`503`	`503`	`}`
`504`	`504`
`505`	`505`	`return $cleared;`