Merge pull request reactphp#156 from WyriHaximus-labs/ext-event_FEATURE_FDS_enabled_by_default

jsor · web-flow · commit 534ce3767a02 · 2018-03-13T11:17:58.000+01:00
ExtEventLoop: Remove optional EventBaseConfig and make FEATURE_FDS enabled by default
diff --git a/src/ExtEventLoop.php b/src/ExtEventLoop.php
@@ -36,8 +36,11 @@ final class ExtEventLoop implements LoopInterface
     private $signals;
     private $signalEvents = array();
 
-    public function __construct(EventBaseConfig $config = null)
+    public function __construct()
     {
+        $config = new EventBaseConfig();
+        $config->requireFeatures(EventBaseConfig::FEATURE_FDS);
+
         $this->eventBase = new EventBase($config);
         $this->futureTickQueue = new FutureTickQueue();
         $this->timerEvents = new SplObjectStorage();
diff --git a/tests/ExtEventLoopTest.php b/tests/ExtEventLoopTest.php
@@ -16,13 +16,7 @@ public function createLoop($readStreamCompatible = false)
             $this->markTestSkipped('ext-event tests skipped because ext-event is not installed.');
         }
 
-        $cfg = null;
-        if ($readStreamCompatible) {
-            $cfg = new \EventConfig();
-            $cfg->requireFeatures(\EventConfig::FEATURE_FDS);
-        }
-
-        return new ExtEventLoop($cfg);
+        return new ExtEventLoop();
     }
 
     public function createStream()

Original file line number	Diff line number	Diff line change
`@@ -16,13 +16,7 @@ public function createLoop($readStreamCompatible = false)`
`16`	`16`	`$this->markTestSkipped('ext-event tests skipped because ext-event is not installed.');`
`17`	`17`	`}`
`18`	`18`
`19`		`- $cfg = null;`
`20`		`- if ($readStreamCompatible) {`
`21`		`- $cfg = new \EventConfig();`
`22`		`- $cfg->requireFeatures(\EventConfig::FEATURE_FDS);`
`23`		`- }`
`24`		`-`
`25`		`- return new ExtEventLoop($cfg);`
	`19`	`+ return new ExtEventLoop();`
`26`	`20`	`}`
`27`	`21`
`28`	`22`	`public function createStream()`